Merge lp:~jerith/txjsonrpc/jsonrpc-2.0-support into lp:txjsonrpc

Proposed by Jeremy Thurgood
Status: Needs review
Proposed branch: lp:~jerith/txjsonrpc/jsonrpc-2.0-support
Merge into: lp:txjsonrpc
Diff against target: 37 lines (+9/-3)
2 files modified
txjsonrpc/jsonrpclib.py (+7/-1)
txjsonrpc/test/test_jsonrpclib.py (+2/-2)
To merge this branch: bzr merge lp:~jerith/txjsonrpc/jsonrpc-2.0-support
Reviewer Review Type Date Requested Status
Duncan McGreggor Pending
Review via email: mp+177605@code.launchpad.net

Description of the change

This builds correctly formatted responses for jsonrpc 2.0 requests.

To post a comment you must log in.
96. By Jeremy Thurgood

Default to v1.0, not the pre-spec behaviour.

Unmerged revisions

96. By Jeremy Thurgood

Default to v1.0, not the pre-spec behaviour.

95. By Jeremy Thurgood

Support v2.0 output.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'txjsonrpc/jsonrpclib.py'
--- txjsonrpc/jsonrpclib.py 2012-01-28 01:11:15 +0000
+++ txjsonrpc/jsonrpclib.py 2013-07-30 14:14:25 +0000
@@ -66,7 +66,13 @@
66 else:66 else:
67 result = obj67 result = obj
68 error = None68 error = None
69 if version == VERSION_PRE1:69 if version == VERSION_2:
70 obj = {"jsonrpc": "2.0", "id": id}
71 if result:
72 obj["result"] = result
73 else:
74 obj["error"] = error
75 elif version == VERSION_PRE1:
70 if result:76 if result:
71 obj = result77 obj = result
72 else:78 else:
7379
=== modified file 'txjsonrpc/test/test_jsonrpclib.py'
--- txjsonrpc/test/test_jsonrpclib.py 2012-01-28 01:11:15 +0000
+++ txjsonrpc/test/test_jsonrpclib.py 2013-07-30 14:14:25 +0000
@@ -52,14 +52,14 @@
52 result = dumps(object, version=VERSION_2)52 result = dumps(object, version=VERSION_2)
53 self.assertEquals(53 self.assertEquals(
54 result,54 result,
55 '{"id": null, "result": {"some": "data"}, "error": null}')55 '{"jsonrpc": "2.0", "id": null, "result": {"some": "data"}}')
5656
57 def test_errorVersion2(self):57 def test_errorVersion2(self):
58 object = Fault("code", "message")58 object = Fault("code", "message")
59 result = dumps(object, version=VERSION_2)59 result = dumps(object, version=VERSION_2)
60 self.assertEquals(60 self.assertEquals(
61 result,61 result,
62 ('{"id": null, "result": null, "error": {"fault": "Fault", '62 ('{"jsonrpc": "2.0", "id": null, "error": {"fault": "Fault", '
63 '"faultCode": "code", "faultString": "message"}}'))63 '"faultCode": "code", "faultString": "message"}}'))
6464
6565

Subscribers

People subscribed via source and target branches

to all changes: