Code review comment for lp:~jeremywootten/slingshot/fix-1213321

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

I have now made the latest changes in trunk compatible with this branch
(only one line required changing). The "Escape" function did not require
changing but the "Shift-Ctrl-V" function did. Changes to the "on_key_press"
function in SlingshotView.vala in trunk could be incompatible with this
branch. In this branch "return base.key_press_event (event);" is not used
in the switch - it is replaced with "break;"

On 10 September 2013 19:37, David Gomes <email address hidden> wrote:

> So if you merge this with the latest trunk you can use Escape to hide
> Slingshot?
> --
>
> https://code.launchpad.net/~jeremywootten/slingshot/fix-1213321/+merge/182058
> You are the owner of lp:~jeremywootten/slingshot/fix-1213321.
>

--
Jeremy Wootten
GPG Key ID CB585BCD
Key Fingerprint 37C0 3C2A A6D4 E45B BA7C 4328 2DF2 1882 CB58 5BCD

« Back to merge proposal