Code review comment for lp:~jeremywootten/slingshot/fix-1213321

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

The reason I left the old code in was in case you wanted to revert to the
old method if and when the Gtk/ibus bug is fixed, but I can take it out. I
will also put in some comments as you suggest.

thanks for the review

On 26 August 2013 14:06, David Gomes <email address hidden> wrote:

> Very much agree with Shnatsel here. Only in rare occasions does code need
> to be commented, and this doesn't seem like one of those.
>
> Besides, I approve of using the EventBox and the code style.
> --
>
> https://code.launchpad.net/~jeremywootten/slingshot/fix-1213321/+merge/182058
> You are the owner of lp:~jeremywootten/slingshot/fix-1213321.
>

--
Jeremy Wootten
GPG Key ID CB585BCD
Key Fingerprint 37C0 3C2A A6D4 E45B BA7C 4328 2DF2 1882 CB58 5BCD

« Back to merge proposal