Terminal

Merge lp:~jeremywootten/pantheon-terminal/revert-geometry-hints-to-toplevel into lp:~elementary-apps/pantheon-terminal/trunk

  1. revert-geometry-hints-to-toplevel
  2. Merge into trunk
Proposed by Jeremy Wootten
Status: Merged
Approved by: Danielle Foré
Approved revision: 843
Merged at revision: 859
Proposed branch: lp:~jeremywootten/pantheon-terminal/revert-geometry-hints-to-toplevel
Merge into: lp:~elementary-apps/pantheon-terminal/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
src/PantheonTerminalWindow.vala (+1/-1)
To merge this branch: bzr merge lp:~jeremywootten/pantheon-terminal/revert-geometry-hints-to-toplevel
Reviewer Review Type Date Requested Status
Zisu Andrei (community) Needs Information
Review via email: mp+295970@code.launchpad.net

Commit message

Apply geometry hints to toplevel window

Description of the change

This reverts a change that was made in r839 in order to permit proper resizing in Ubuntu Unity. Unfortunately this led to a regression that caused gradual shrinking of the window when the search revealer was toggled.

To post a comment you must log in.
Revision history for this message
Zisu Andrei (matzipan) wrote :

Is this still applicable?

review: Needs Information
Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

The window shrinking is still happening to me.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/PantheonTerminalWindow.vala'
2--- src/PantheonTerminalWindow.vala 2016-05-26 17:55:00 +0000
3+++ src/PantheonTerminalWindow.vala 2016-05-27 16:17:07 +0000
4@@ -573,7 +573,7 @@
5 Gdk.Geometry hints = Gdk.Geometry();
6 hints.width_inc = (int) t.get_char_width ();
7 hints.height_inc = (int) t.get_char_height ();
8- set_geometry_hints (tab, hints, Gdk.WindowHints.RESIZE_INC);
9+ set_geometry_hints (this, hints, Gdk.WindowHints.RESIZE_INC);
10
11 notebook.insert_tab (tab, -1);
12 notebook.current = tab;

Subscribers

People subscribed via source and target branches