Files

Merge lp:~jeremywootten/pantheon-files/fix-window-sizing into lp:~elementary-apps/pantheon-files/trunk

  1. fix-window-sizing
  2. Merge into trunk
Proposed by Jeremy Wootten
Status: Merged
Approved by: Danielle Foré
Approved revision: 2103
Merged at revision: 2111
Proposed branch: lp:~jeremywootten/pantheon-files/fix-window-sizing
Merge into: lp:~elementary-apps/pantheon-files/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
src/View/Window.vala (+1/-1)
To merge this branch: bzr merge lp:~jeremywootten/pantheon-files/fix-window-sizing
Reviewer Review Type Date Requested Status
elementary Apps team Pending
Review via email: mp+291594@code.launchpad.net

Commit message

Use 'connect_after ()' for Window configure-event handler to allow tiling to work properly.

Description of the change

This branch fixes bugs related to tiling of the window not working for Files under some circumstances, due to a Files signal handler linked to the "configure" event of the window interfering with Gala in some way. The bug goes away if "connect_after" is used for the Files handler.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/View/Window.vala'
2--- src/View/Window.vala 2016-02-29 11:33:21 +0000
3+++ src/View/Window.vala 2016-04-12 09:05:00 +0000
4@@ -152,7 +152,7 @@
5 tabs.show_tabs = true;
6 tabs.allow_restoring = true;
7 tabs.allow_duplication = true;
8- this.configure_event.connect ((e) => {
9+ this.configure_event.connect_after ((e) => {
10 tabs.set_size_request (e.width / 2, -1);
11 return false;
12 });

Subscribers

People subscribed via source and target branches

to all changes: