Merge lp:~jeremywootten/pantheon-files/fix-sidebar-dragging into lp:~elementary-apps/pantheon-files/trunk
Proposed by
Jeremy Wootten
Status: | Merged | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Approved by: | Cody Garver | ||||||||||||
Approved revision: | 1884 | ||||||||||||
Merged at revision: | 1885 | ||||||||||||
Proposed branch: | lp:~jeremywootten/pantheon-files/fix-sidebar-dragging | ||||||||||||
Merge into: | lp:~elementary-apps/pantheon-files/trunk | ||||||||||||
Diff against target: |
291 lines (+115/-56) 1 file modified
src/View/Sidebar.vala (+115/-56) |
||||||||||||
To merge this branch: | bzr merge lp:~jeremywootten/pantheon-files/fix-sidebar-dragging | ||||||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Fabio Zaramella (community) | Approve | ||
Cody Garver | Pending | ||
Review via email: mp+265188@code.launchpad.net |
Commit message
Dragging a bookmark off the sidebar now properly removes it (lp:1473754)
Disallow dragging bookmarks that cannot be removed (lp:1474410)
Description of the change
This branch fixes issues related to the dragging and dropping of bookmarks caused by the selected bookmark sometimes changing after drag started:
Dragging off the sidebar did not destroy the bookmark unless it was current view
Dragging an unselected bookmark could have unexpected results.
Also dragging is inhibited for bookmarks that are not intended to be moved.
To post a comment you must log in.
Works fine.