Merge lp:~jeremywootten/pantheon-files/fix-notification-part4 into lp:~elementary-apps/pantheon-files/trunk

Proposed by Jeremy Wootten
Status: Merged
Approved by: Zisu Andrei
Approved revision: 2240
Merge reported by: Zisu Andrei
Merged at revision: not available
Proposed branch: lp:~jeremywootten/pantheon-files/fix-notification-part4
Merge into: lp:~elementary-apps/pantheon-files/trunk
Diff against target: 20 lines (+0/-11)
1 file modified
src/ProgressUIHandler.vala (+0/-11)
To merge this branch: bzr merge lp:~jeremywootten/pantheon-files/fix-notification-part4
Reviewer Review Type Date Requested Status
elementary Apps team Pending
Review via email: mp+299628@code.launchpad.net

Commit message

Do not set "Urgent" if the app does not recieve attention for 2 seconds

Description of the change

ProgressUIHandler no longer sets the unity entry to "urgent" for 2 seconds when file operations end.

To post a comment you must log in.
Revision history for this message
Zisu Andrei (matzipan) wrote :

Whoopsie, had this tab open since yesterday and forgot to refresh it before marking as accepted. Apologies.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/ProgressUIHandler.vala'
2--- src/ProgressUIHandler.vala 2016-07-06 22:28:54 +0000
3+++ src/ProgressUIHandler.vala 2016-07-10 18:24:44 +0000
4@@ -289,17 +289,6 @@
5 unity_lentry.progress_visible = false;
6 unity_lentry.progress = 0.0;
7 show_unity_quicklist (marlin_lentry, false);
8-
9- Cancellable pc = info.get_cancellable ();
10-
11- if (!pc.is_cancelled ()) {
12- unity_lentry.urgent = true;
13-
14- Timeout.add_seconds (2, () => {
15- unity_lentry.urgent = false;
16- return false;
17- });
18- }
19 }
20 }
21

Subscribers

People subscribed via source and target branches

to all changes: