lp:~jeremywootten/pantheon-files/fix-context-menu-bookmark-option-for-network-folders
This branch fixes a bug where certain network folders could not be bookmarked using the context menu because their path matched that of the network mount (often the user home directory). This intention was to exclude duplicate bookmarks but network mount items are not bookmarks since they disappear when unmounted. Now only true bookmarks are used when checking for duplicates.
It is noted that Ctrl-D excludes this check but BookmarkList will not create duplicates anyway. The sidebar check is only to avoid offering an action that will fail (to bookmark a folder that is already bookmarked).
- Get this branch:
- bzr branch lp:~jeremywootten/pantheon-files/fix-context-menu-bookmark-option-for-network-folders
Branch merges
- Kirill Romanov (community): Approve (test)
- elementary Apps team: Pending requested
-
Diff: 44 lines (+7/-6)2 files modifiedsrc/View/Sidebar.vala (+5/-5)
src/View/Window.vala (+2/-1)
Related bugs
Bug #1668046: Can't add user's folder when connecting by SSH | Medium | Fix Released |
Related blueprints
Branch information
Recent revisions
- 2513. By Launchpad Translations on behalf of elementary-apps
-
Launchpad automatic translations update.
- 2512. By Launchpad Translations on behalf of elementary-apps
-
Launchpad automatic translations update.
- 2511. By Jeremy Wootten
-
Various changes aimed at improving the connection and loading of network sites and fixes some possible bugs.
A new warning screen is shown if the connection or loading operation times out. Pressing reload under these conditions unmounts any connection and starts again.
GOF.File mount is set to the enclosing_mount when the location is not the root location.
- 2507. By Launchpad Translations on behalf of elementary-apps
-
Launchpad automatic translations update.
- 2506. By Launchpad Translations on behalf of elementary-apps
-
Launchpad automatic translations update.
- 2505. By Launchpad Translations on behalf of elementary-apps
-
Launchpad automatic translations update.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:~elementary-apps/pantheon-files/trunk