Merge lp:~jeremywootten/pantheon-files/fix-1604300-merge-find-functionalities-part1 into lp:~elementary-apps/pantheon-files/trunk
Proposed by
Jeremy Wootten
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Danielle Foré | ||||||||
Approved revision: | 2415 | ||||||||
Merged at revision: | 2445 | ||||||||
Proposed branch: | lp:~jeremywootten/pantheon-files/fix-1604300-merge-find-functionalities-part1 | ||||||||
Merge into: | lp:~elementary-apps/pantheon-files/trunk | ||||||||
Diff against target: |
199 lines (+21/-50) 6 files modified
libwidgets/Interfaces/SearchableInterface.vala (+0/-2) libwidgets/View/SearchResults.vala (+4/-29) src/View/AbstractDirectoryView.vala (+2/-1) src/View/Widgets/LocationBar.vala (+6/-3) src/View/Widgets/TopMenu.vala (+2/-2) src/View/Window.vala (+7/-13) |
||||||||
To merge this branch: | bzr merge lp:~jeremywootten/pantheon-files/fix-1604300-merge-find-functionalities-part1 | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Danielle Foré | Approve | ||
Review via email:
|
Commit message
Combine the two search modes. Ctrl + F and Type-ahead now do the same thing
Description of the change
This branch removes the two modes of search (current folder/begins-with and global/contains) - search now always performs the full search.
To post a comment you must log in.
As far as I can tell, this branch makes the full search appear when typing but it:
* Makes Ctrl + F not do anything at all. This is probably unexpected.
* Breaks the type-ahead filter feature by not prioritizing results from the pwd.
I think I would consider merging this as is to introduce regressions