Merge lp:~jeremywootten/pantheon-files/fix-1042439-open-link-type-desktop-files-correctly into lp:~elementary-apps/pantheon-files/trunk

Proposed by Jeremy Wootten
Status: Merged
Approved by: Cody Garver
Approved revision: 2113
Merged at revision: 2114
Proposed branch: lp:~jeremywootten/pantheon-files/fix-1042439-open-link-type-desktop-files-correctly
Merge into: lp:~elementary-apps/pantheon-files/trunk
Diff against target: 24 lines (+4/-4)
1 file modified
libcore/gof-file.c (+4/-4)
To merge this branch: bzr merge lp:~jeremywootten/pantheon-files/fix-1042439-open-link-type-desktop-files-correctly
Reviewer Review Type Date Requested Status
elementary Apps team Pending
Review via email: mp+291924@code.launchpad.net

Commit message

Check if is desktop file first in gof_file_is_executable ()

Description of the change

This branch fixes the linked bug by ensuring that desktop files are treated as executables.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libcore/gof-file.c'
2--- libcore/gof-file.c 2016-04-03 17:28:42 +0000
3+++ libcore/gof-file.c 2016-04-14 17:37:36 +0000
4@@ -1446,16 +1446,16 @@
5
6 g_return_val_if_fail (GOF_IS_FILE (file), FALSE);
7
8+ if (gof_file_is_desktop_file (file)) {
9+ return TRUE;
10+ }
11+
12 if (file->target_gof)
13 return gof_file_is_executable (file->target_gof);
14 if (file->info == NULL) {
15 return FALSE;
16 }
17
18- if (gof_file_is_desktop_file (file)) {
19- return TRUE;
20- }
21-
22 if (g_file_info_get_attribute_boolean (file->info, G_FILE_ATTRIBUTE_ACCESS_CAN_EXECUTE))
23 {
24 /* get the content type of the file */

Subscribers

People subscribed via source and target branches

to all changes: