Files

Merge lp:~jeremywootten/pantheon-files/do-not-present-in-construct-in-AbstractPropertiesDialog into lp:~elementary-apps/pantheon-files/trunk

  1. do-not-present-in-construct-in-AbstractPropertiesDialog
  2. Merge into trunk
Proposed by Jeremy Wootten
Status: Merged
Approved by: David Hewitt
Approved revision: 2517
Merged at revision: 2528
Proposed branch: lp:~jeremywootten/pantheon-files/do-not-present-in-construct-in-AbstractPropertiesDialog
Merge into: lp:~elementary-apps/pantheon-files/trunk
Diff against target: 12 lines (+0/-2)
1 file modified
src/Dialogs/AbstractPropertiesDialog.vala (+0/-2)
To merge this branch: bzr merge lp:~jeremywootten/pantheon-files/do-not-present-in-construct-in-AbstractPropertiesDialog
Reviewer Review Type Date Requested Status
David Hewitt code, function Approve
Review via email: mp+318812@code.launchpad.net

Commit message

Calling present () in the construct clause of AbstractPropertiesDialog is unnecessary and causes a terminal warning : WARNING 17:17:27.650174] [Gtk] gtk_window_set_titlebar() called on a realized window.

Description of the change

Calling present () in the construct clause of AbstractPropertiesDialog is unnecessary and causes a terminal warning : WARNING 17:17:27.650174] [Gtk] gtk_window_set_titlebar() called on a realized window.

To post a comment you must log in.
Revision history for this message
David Hewitt (davidmhewitt) wrote :

Agree that present shouldn't be called here. The window still appears fine and the warning is gone.

review: Approve (code, function)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Dialogs/AbstractPropertiesDialog.vala'
2--- src/Dialogs/AbstractPropertiesDialog.vala 2017-02-10 19:35:18 +0000
3+++ src/Dialogs/AbstractPropertiesDialog.vala 2017-03-02 17:18:35 +0000
4@@ -82,8 +82,6 @@
5 break;
6 }
7 });
8-
9- present ();
10 }
11
12 protected void create_header_title () {

Subscribers

People subscribed via source and target branches

to all changes: