Merge lp:~jeremywootten/granite/remove-deprecated-resize-children-in-storagebar into lp:~elementary-pantheon/granite/granite

Proposed by Jeremy Wootten on 2017-03-02
Status: Merged
Approved by: Daniel Fore on 2017-04-21
Approved revision: 1038
Merged at revision: 1045
Proposed branch: lp:~jeremywootten/granite/remove-deprecated-resize-children-in-storagebar
Merge into: lp:~elementary-pantheon/granite/granite
Diff against target: 18 lines (+0/-2)
1 file modified
lib/Widgets/StorageBar.vala (+0/-2)
To merge this branch: bzr merge lp:~jeremywootten/granite/remove-deprecated-resize-children-in-storagebar
Reviewer Review Type Date Requested Status
Daniel Fore 2017-03-02 Approve on 2017-04-21
Review via email: mp+318805@code.launchpad.net

Commit message

StorageBar.vala: remove deprecated resize_children

Description of the change

This branch removes some deprecated and unnecessary lines from StorageBar.vala. These lines were causing critical terminal warnings from the PropertiesWindow in pantheon-files.

To post a comment you must log in.
Daniel Fore (danrabbit) wrote :

afaik works fine

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/Widgets/StorageBar.vala'
2--- lib/Widgets/StorageBar.vala 2016-12-31 19:48:54 +0000
3+++ lib/Widgets/StorageBar.vala 2017-03-02 17:07:43 +0000
4@@ -79,7 +79,6 @@
5
6 set {
7 _storage = value;
8- resize_children ();
9 update_size_description ();
10 }
11 }
12@@ -93,7 +92,6 @@
13
14 set {
15 _total_usage = uint64.min (value, storage);
16- resize_children ();
17 update_size_description ();
18 }
19

Subscribers

People subscribed via source and target branches