Merge lp:~jeremywootten/appcenter/fix-1624186-reappear-after-install into lp:~elementary-apps/appcenter/appcenter

[Jeremy Wootten]

ensure that changes_information is cleared from a package after successful updating so that the "updates_available" property returns the correct value.

This branch ensures the changes_information are cleared from a package after successful updating so that the "updates_available" property returns the correct value.

[Danielle Foré (danrabbit)]

Does what it says on the tin

review: Approve

=== modified file 'src/Core/Client.vala'
--- src/Core/Client.vala	2016-09-11 20:19:38 +0000
+++ src/Core/Client.vala	2016-09-17 13:56:59 +0000
@@ -160,19 +160,21 @@
             sc.inhibit ();
             var results = yield update_task.update_packages_async (packages_ids, cancellable, cb);
             exit_status = results.get_exit_code ();
-            if (exit_status != Pk.Exit.SUCCESS) {
-                release_task (update_task);
-                throw new GLib.IOError.FAILED (Pk.Exit.enum_to_string (results.get_exit_code ()));
-            }
         } catch (Error e) {
-            release_task (update_task);
             throw e;
         } finally {
             sc.uninhibit ();
+            release_task (update_task);
+        }
+
+        if (exit_status != Pk.Exit.SUCCESS) {
+            throw new GLib.IOError.FAILED (Pk.Exit.enum_to_string (exit_status));
+        } else {
+            package.change_information.clear_update_info ();
         }
 
         yield refresh_updates ();
-        release_task (update_task);
+
         return exit_status;
     }