Merge lp:~jeremy-munsch/synapse-project/fix-ssh-terminal into lp:synapse-project
Proposed by
Jeremy Munsch
Status: | Merged |
---|---|
Merged at revision: | 664 |
Proposed branch: | lp:~jeremy-munsch/synapse-project/fix-ssh-terminal |
Merge into: | lp:synapse-project |
Diff against target: |
118 lines (+64/-22) 3 files modified
src/core/common-actions.vala (+1/-11) src/core/utils.vala (+62/-0) src/plugins/ssh-plugin.vala (+1/-11) |
To merge this branch: | bzr merge lp:~jeremy-munsch/synapse-project/fix-ssh-terminal |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Rico Tzschichholz | Pending | ||
Review via email: mp+277061@code.launchpad.net |
Description of the change
Use
x-terminal-
to respect user default terminal instead of unefficient Glib default terminal
https:/
It is only launching gnome-terminal or xterm, this is not the wanted behaviour.
The -e should work with any terminal emulator, this is i think a reliable and simple solution since synapse is targeting Debian based distros.
The fallback still supports other DE though.
To post a comment you must log in.
I just saw in common actions that the problem is also to fix there.
I will also test if x-terminal-emulator is present and fall back to GLib solution if not.
I think of refactoring this into an Utils method.