Code review comment for lp:~jeremy-munsch/synapse-project/fix-notification

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

Looks reasonable, but do not be lazy! "n" is not a good variable name at all. So "notification" it is.

More of a problem is the implicit bump to glib >= 2.40 which could use some thinking.

review: Needs Fixing

« Back to merge proposal