Merge lp:~jeremy-munsch/synapse-project/fix-chromium-plugin into lp:synapse-project

[Jeremy Munsch]

add mime_type: Uri.parse_scheme (url), to BookmarkMatch in ChromiumPlugin since it extends UriMatch

[lp:~jeremy-munsch/synapse-project/fix-chromium-plugin]

616. By Jeremy Munsch on 2015-11-14

core: Handle UriMatches pointing to executable files

617. By Rico Tzschichholz on 2015-11-14

build: Drop optional dependency on gnome-common

618. By Rico Tzschichholz on 2015-11-14

build: Bump requirements glib-2.0 >= 2.40, valac >= 0.24.0

619. By Jeremy Munsch on 2015-11-14

Add support for "Additional applications actions"

Source and evaluate "Desktop Action" groups in desktop-files.

[Rico Tzschichholz (ricotz)]

"Uri.parse_scheme (url)" is not a mime-type. I would assume setting it to "text/html" should work.

review: Needs Information

[Jeremy Munsch (jeremy-munsch)]

Correct, i made correction to use "text/html"

[Rico Tzschichholz (ricotz)]

Hmm, look at your diff and think again. No need for a comment either.

review: Needs Fixing

[Jeremy Munsch (jeremy-munsch)]

Omg, how could i dare be so stupid, shame on me. Just made required corrections.
Sorry about that.

[Rico Tzschichholz (ricotz)]

Please don't explicitly reference the changed files in your commit message. (Same goes for your other merges). The VCS is perfectly capable to provide such information.

One line summary, and *if* needed a longer description separated by a blank-line

"chromium: Set mime-type of BookmarkMatch"

[Jeremy Munsch (jeremy-munsch)]

Ok i'll do that in the future, and update my other PR.

[lp:~jeremy-munsch/synapse-project/fix-chromium-plugin]

620. By Jeremy Munsch on 2015-11-14

chromium: Set mime-type of BookmarkMatch

[Jeremy Munsch (jeremy-munsch)]

Just updated branch

[Rico Tzschichholz (ricotz)]

review: Approve

=== modified file 'src/plugins/chromium-plugin.vala'
--- src/plugins/chromium-plugin.vala	2014-07-16 09:52:18 +0000
+++ src/plugins/chromium-plugin.vala	2015-11-14 23:51:13 +0000
@@ -54,6 +54,7 @@
         Object (title: name,
                 description: url,
                 uri: url,
+                mime_type: "text/html",
                 has_thumbnail: false, icon_name: "text-html");
       }
     }