Merge lp:~jeremy-munsch/synapse-project/firefox-plugin into lp:synapse-project

[Jeremy Munsch]

Changed file operation plugin: is now valid for file scheme only - this to remove delete on other schemes as it is not supported at all -
Added Firefox plugin,

Is capable of making search in bookmarks and history.
It handles all user profiles and firefox canals (normal, beta, aurora (dev edition), nightly)

Provides Action to refresh Bookmarks, and search through History (with performance in mind, well I tried)

[Jeremy Munsch (jeremy-munsch)]

Working on addressing multiple issues.

[Jeremy Munsch (jeremy-munsch)]

Updated, there is now some serious performance improvements.

Still to be handle maybe is the results MatchScore. Currently they are all on the same level or results order seems weird, this could have some more investigation.

[Jeremy Munsch (jeremy-munsch)]

Note :

Some thing very weird is the results for "2e rima"

[INFO 11:35:20.715979] [firefox-plugin:391] 2e RIMa
[INFO 11:35:20.716032] [firefox-plugin:392] matcher 100000
[INFO 11:35:20.722415] [firefox-plugin:396] " The Kevin Bowser Group "
[INFO 11:35:20.722473] [firefox-plugin:397] matcher 100000
[INFO 11:35:20.829951] [firefox-plugin:396] " The Kevin Bowser Group "
[INFO 11:35:20.830008] [firefox-plugin:397] matcher 90000
[INFO 11:35:20.930300] [firefox-plugin:396] " The Kevin Bowser Group "
[INFO 11:35:20.930358] [firefox-plugin:397] matcher 85000
[INFO 11:35:21.029067] [firefox-plugin:396] " The Kevin Bowser Group "
[INFO 11:35:21.029124] [firefox-plugin:397] matcher 80000
[INFO 11:35:21.131601] [firefox-plugin:396] " The Kevin Bowser Group "
[INFO 11:35:21.131690] [firefox-plugin:397] matcher 78000
[INFO 11:35:21.234236] [firefox-plugin:396] " The Kevin Bowser Group "
[INFO 11:35:21.234310] [firefox-plugin:397] matcher 60000
[INFO 11:35:21.339622] [firefox-plugin:396] " The Kevin Bowser Group "
[INFO 11:35:21.339680] [firefox-plugin:397] matcher 50000

Something seems broken here.

[Jeremy Munsch (jeremy-munsch)]

Same log as above with associated regex
http://paste.ubuntu.com/13363445/

This is a complete non sense how could
[INFO 11:56:49.116434] [firefox-plugin:397] regex ^(2e rima)$
[INFO 11:56:49.116478] [firefox-plugin:398] 2e rima " The Kevin Bowser Group "
[INFO 11:56:49.116511] [firefox-plugin:399] matcher 100000

that be matching ?

(second line is query + searchedtitle)

[Jeremy Munsch (jeremy-munsch)]

OK this is now cristal clear, with my silly comments above (just likely to be ignored).
Using Fuzzy search was a complete non sense here. I just removed then and now results are relevant.

I also have to say even if the code may seems to not be the best, every thing was very well handled in terms of performances and stability.

I will update the branch with the last changes and it should be very ready.

[Jeremy Munsch (jeremy-munsch)]

Note:

Moz profiles contains search.json, which are the opensearch engines used by Firefox, this will benefit opensearch plugin as a data source in a another work.

[Jeremy Munsch (jeremy-munsch)]

This plugin is now ready at its best, to be reviewed.

[Rico Tzschichholz (ricotz)]

regarding r629 better propose this separately, but I guess I might just push this:
https://paste.debian.net/plain/334259

On the actual topic here, this will take a while since I don't know where I would begin to clean things up :\

* get_fqdn() looks horrible while I could imaging there are glib functions for this
* Look into using GMutex
* Don't misuse static fields in some internal enum/struct declarations
* Avoid using all those static fields
* try to sort your code a bit (from top to bottom: consts, statics, normal methods)
* Are there multiple errordomains needed

It would be better if you look at it yourself again and give it another iterations!

review: Needs Fixing

[Jeremy Munsch (jeremy-munsch)]

OK thank you, I'm working on this.

* get_fqdn() I could not find parsing functions on all available libs, libsoup is the one to be used but including one lib for one secondary function/use would be overkilled i guess. I could also look for an existing pseudo code solution, but I could not find such a thing at the time.
I could also try to use Regex.replace, but i have to say to is also overkilled since perfect url regex do not exists at all, I know that well. I'll try to find something although.

[Jeremy Munsch (jeremy-munsch)]

Correct me if I'm wrong but mutex are not compatible with async functions as it is runned in this case by the Display/main thread, this would not work. I should have renamed the var to semaphore.

The goal here is to make all search requests (character typed) wait for the current search thread to finish. When it does, a signal is sent to all search requests and all are dismissed except the most recent one which is allow to start the search thread.

This avoids creating a thread per keyboard hit. despite I named my variable mutex, there are no critical resources to be protected in the Thread code. I also have and i7 so it won't bother me to have one thread per character but the search could last 1-2 seconds to find in all your history. So having a behaviour similar to "non retriggerable monostable" is likely to be to most performante way to proceed here.

Still making some cleanup as possible although

[Jeremy Munsch (jeremy-munsch)]

Ok I just made some clean-up according your previous comment.
I was also able to reduce amounts of code here.

I added some comment on top explaining choices i've made and how the plugin works.

[Jeremy Munsch (jeremy-munsch)]

Updated commit message

[lp:~jeremy-munsch/synapse-project/firefox-plugin]

633. By Jeremy Munsch on 2015-12-02

add firefox plugin for bookmarks and history
add sqlite3 dependency

[Jeremy Munsch (jeremy-munsch)]

removed "using Sqlite;"

[Jeremy Munsch (jeremy-munsch)]

As a note here, and as mentionned by Rico, usage of threads would need this https://git.launchpad.net/plank/tree/lib/Items/ApplicationDockItem.vala#n397

[Jeremy Munsch (jeremy-munsch)]

Damn it wrong link i meant this https://git.launchpad.net/plank/tree/lib/Services/Worker.vala

[Rico Tzschichholz (ricotz)]

I didnt say this is *needed*. It is a more resource friendly method using a ThreadPool to have an amount of ready-to-use threads available and to avoid creating an arbitrary number of threads in unlucky cases.

Unmerged revisions

633. By Jeremy Munsch on 2015-12-02

add firefox plugin for bookmarks and history
add sqlite3 dependency

=== modified file 'configure.ac'
--- configure.ac	2015-11-14 20:50:37 +0000
+++ configure.ac	2015-12-02 20:28:49 +0000
@@ -62,7 +62,8 @@
   gee-0.8 >= $MIN_GEE_VERSION \
   json-glib-1.0 >= $MIN_JSON_VERSION \
   keybinder-3.0 \
-  libnotify
+  libnotify \
+  sqlite3
   )
 SYNAPSE_MODULES_VALAFLAGS=" --pkg gdk-x11-3.0 \
   --pkg gtk+-3.0 \
@@ -71,7 +72,8 @@
   --pkg gee-0.8 \
   --pkg json-glib-1.0 \
   --pkg keybinder-3.0 \
-  --pkg libnotify"
+  --pkg libnotify \
+  --pkg sqlite3"
 AC_SUBST(SYNAPSE_MODULES_VALAFLAGS)
 
 SYNAPSE_COMMON_VALAFLAGS=" --target-glib=2.40 --thread -g"

=== modified file 'debian/control'
--- debian/control	2015-11-30 14:47:10 +0000
+++ debian/control	2015-12-02 20:28:49 +0000
@@ -15,6 +15,7 @@
  libkeybinder-3.0-dev,
  libnotify-dev,
  librest-dev,
+ libsqlite3,
  libappindicator3-dev (>= 0.0.7)
 Vcs-Bzr: http://bazaar.launchpad.net/~synapse-core/synapse-project/trunk/
 Vcs-Browser: http://bazaar.launchpad.net/~synapse-core/synapse-project/trunk/files

=== modified file 'src/core/data-sink.vala'
--- src/core/data-sink.vala	2014-07-10 11:39:28 +0000
+++ src/core/data-sink.vala	2015-12-02 20:28:49 +0000
@@ -480,6 +480,12 @@
 
       return rs.get_sorted_list ();
     }
+
+    public signal void plugin_reseted ();
+    public void reset_plugins ()
+    {
+      plugin_reseted ();
+    }
   }
 }
 

=== modified file 'src/core/utils.vala'
--- src/core/utils.vala	2015-11-19 09:11:34 +0000
+++ src/core/utils.vala	2015-12-02 20:28:49 +0000
@@ -46,6 +46,12 @@
       return result;
     }
 
+    public static string replace_first_occurence (string subject, string old, string replacement = "")
+    {
+      int pos = subject.index_of (old);
+      return "%s%s%s".printf (subject.substring (0, pos), replacement, subject.substring (pos + old.length));
+    }
+
     public static string? remove_last_unichar (string input)
     {
       long char_count = input.char_count ();

=== modified file 'src/plugins/Makefile.am'
--- src/plugins/Makefile.am	2015-07-21 08:13:23 +0000
+++ src/plugins/Makefile.am	2015-12-02 20:28:49 +0000
@@ -37,6 +37,7 @@
 	ssh-plugin.vala \
 	dictionary.vala \
 	directory-plugin.vala \
+	firefox-plugin.vala \
 	gnome-bookmarks-plugin.vala \
 	gnome-session-plugin.vala \
 	gnome-screensaver-plugin.vala \

=== added file 'src/plugins/firefox-plugin.vala'
--- src/plugins/firefox-plugin.vala	1970-01-01 00:00:00 +0000
+++ src/plugins/firefox-plugin.vala	2015-12-02 20:28:49 +0000
@@ -0,0 +1,668 @@
+/*
+ * Copyright (C) 2015 Jérémy Munsch <[e-mail]>
+ *
+ * This program is free software: you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the
+ * Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
+ * See the GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ *
+ * Performance notes:
+ *
+ * Sqlite databases can be hudge, blocking synapse,
+ * so using Threads is required in this plugin
+ *
+ * Only one search is conducted at a time,
+ * and then when it finishes a signal is sent
+ * to other search requests waiting and only
+ * the most recent one is allowed to be run.
+ *
+ * Note : path variables would be used by other plugins
+ * eg : opensearch plugin
+ * therefore they are meant to be static
+ *
+ *
+ * --- How it works ---
+ *
+ * This plugin is looking into ~/.mozilla/{firefox,firefox-trunk}
+ * for user profiles by reading ini files, then parsing places.sql
+ *
+ * It searches in moz_bookmarks, moz_historyvisits, moz_places
+ * History and bookmarks hashmaps are stored in Profiles.
+ * Each profil has a canal associated (Firefox, FirefoxTrunk)
+ *
+ * Bookmarks is searched in all canals, but History is search
+ * in canals separatly (two History search Actions)
+ *
+ * Selecting an action stays memorized until another action is
+ * choosen or Synapse Hidden (close event added here)
+ * This means by selecting Search in FirefoxTrunk history
+ * all search are conducted in it until antoher action is
+ * choosen or Synapse Hidden.
+ *
+ */
+
+namespace Synapse
+{
+  private errordomain ProfileParseError { ERROR }
+
+  public class FirefoxPlugin : Object, Activatable, ItemProvider, ActionProvider
+  {
+
+
+    public unowned DataSink data_sink { get; construct; }
+
+    public bool enabled { get; set; default = true; }
+    private bool search_busy = false;
+    private static uint last_registered_signal_id = 0;
+
+    private signal void search_completed ();
+
+    private static unowned DesktopFileInfo firefox_app_info { set; get; default = null; }
+    private static unowned DesktopFileInfo firefoxtrunk_app_info  { set; get; default = null; }
+    private static FirefoxCanal firefox_canal { get; set; default = FirefoxCanal.NOFIREFOX; }
+    public static Gee.List<string> firefox_profiles_paths;
+    public static Gee.List<FirefoxProfile?> firefox_profiles;
+    public static string firefox_root_dir { get; private set; default = ".mozilla"; }
+
+    private FirefoxCanal search_using_canal { get; set; default = FirefoxCanal.FIREFOXALL; }
+    private bool use_history;
+    private RefreshBookmarks refresh_action;
+    private SearchHistory history_action_firefox;
+    private SearchHistory history_action_firefoxtrunk;
+
+
+    /**
+     * Plugin Objects
+     */
+
+    public enum FirefoxCanal
+    {
+      NOFIREFOX,
+      FIREFOX = 1 << 0,
+      FIREFOXTRUNK = 1 << 1,
+      FIREFOXALL = ~0;
+
+      public string to_string ()
+      {
+        switch (this)
+        {
+          case FirefoxCanal.FIREFOX:
+            return "firefox";
+          case FirefoxCanal.FIREFOXTRUNK:
+            return "firefox-trunk";
+          default:
+            return "";
+        }
+      }
+
+      public string display ()
+      {
+        switch (this)
+        {
+          case FirefoxCanal.FIREFOX:
+            return null != firefox_app_info ? firefox_app_info.name : "Firefox";
+          case FirefoxCanal.FIREFOXTRUNK:
+            return null != firefoxtrunk_app_info ? firefoxtrunk_app_info.name : "Nightly";
+          default:
+            return null != firefox_app_info ? firefox_app_info.name : "Firefox";
+        }
+      }
+
+      public FirefoxCanal from_string (string canal)
+      {
+        switch (canal)
+        {
+          case "firefox":
+            return FirefoxCanal.FIREFOX;
+          case "firefox-trunk":
+            return FirefoxCanal.FIREFOXTRUNK;
+          default:
+            return FirefoxCanal.NOFIREFOX;
+        }
+      }
+    }
+    public struct FirefoxProfile
+    {
+      public bool is_default;
+      public string name;
+      public string path;
+      public FirefoxCanal type;
+      public Gee.HashMap<string, BookmarkMatch> bookmarks;
+      public Gee.HashMap<string, HistoryMatch> history;
+    }
+
+    public class BookmarkMatch : UriMatch
+    {
+      public BookmarkMatch (string name, string url)
+      {
+        Object (title: name,
+                description: url,
+                uri: url,
+                mime_type: "text/html",
+                has_thumbnail: false, icon_name: "bookmarks");
+      }
+    }
+
+    public class HistoryMatch : UriMatch
+    {
+      public int default_relevancy { get; set; default = MatchScore.INCREMENT_SMALL; }
+      public HistoryMatch (string name, string url)
+      {
+        Object (title: name,
+                description: url,
+                uri: url,
+                mime_type: "text/html",
+                has_thumbnail: false, icon_name: "bookmarks");
+      }
+    }
+
+    private class RefreshBookmarks : SearchMatch
+    {
+      public int default_relevancy { get; set; default = MatchScore.INCREMENT_SMALL; }
+      private unowned FirefoxPlugin plugin;
+      public FirefoxCanal canal { get; set; default = FirefoxCanal.FIREFOXALL; }
+
+      public RefreshBookmarks (FirefoxPlugin plugin, FirefoxCanal search_canal)
+      {
+        Object (has_thumbnail: false,
+                icon_name: "firefox",
+                title: _("Refresh %s bookmarks".printf (search_canal.display ())),
+                description: _("Try to search by refreshing %s bookmarks".printf (search_canal.display ())));
+        this.plugin = plugin;
+        canal = search_canal;
+      }
+
+      // for SearchMatch interface
+      public override async Gee.List<Match> search (string query,
+                                           QueryFlags flags,
+                                           ResultSet? dest_result_set,
+                                           Cancellable? cancellable = null) throws SearchError
+      {
+        var q = Query (0, query, flags);
+        q.cancellable = cancellable;
+
+        try
+        {
+          Thread<void*> init = new Thread<void*>.try ("FirefoxPluginRefreshBookmarks", () => {
+            plugin.parse_bookmarks ();
+            Idle.add (search.callback);
+            return null;
+          });
+          yield;
+          if (null == init)
+          {
+            plugin.data_sink.set_plugin_enabled (typeof (FirefoxPlugin), false);
+            throw new ThreadError.AGAIN ("Firefox Plugin init Refresh Bookmarks thread failed, deactivating plugin");
+          }
+        }
+        catch (Error e)
+        {
+          warning ("%s".printf (e.message));
+          plugin.data_sink.set_plugin_enabled (typeof (FirefoxPlugin), false);
+          return dest_result_set.get_sorted_list ();
+        }
+
+        plugin.use_history = false;
+        plugin.search_using_canal = canal;
+        ResultSet? results = yield plugin.search (q);
+        dest_result_set.add_all (results);
+
+        return dest_result_set.get_sorted_list ();
+      }
+    }
+
+    private class SearchHistory : SearchMatch
+    {
+      public int default_relevancy { get; set; default = MatchScore.INCREMENT_SMALL; }
+      private unowned FirefoxPlugin plugin;
+      public FirefoxCanal canal { get; set; default = FirefoxCanal.FIREFOXALL; }
+
+      public SearchHistory (FirefoxPlugin plugin, FirefoxCanal search_canal)
+      {
+        Object (has_thumbnail: false,
+                icon_name: "firefox",
+                title: _("Search in %s history".printf (search_canal.display ())),
+                description: _("Try to search in %s history".printf (search_canal.display ())));
+        this.plugin = plugin;
+        canal = search_canal;
+      }
+
+      // for SearchMatch interface
+      public override async Gee.List<Match> search (string query,
+                                           QueryFlags flags,
+                                           ResultSet? dest_result_set,
+                                           Cancellable? cancellable = null) throws SearchError
+      {
+        var q = Query (0, query, flags);
+        q.cancellable = cancellable;
+
+        try
+        {
+          Thread<void*> init = new Thread<void*>.try ("FirefoxPluginSearchHistory", () => {
+            plugin.parse_histories ();
+            Idle.add (search.callback);
+            return null;
+          });
+          yield;
+          if (null == init)
+          {
+            plugin.data_sink.set_plugin_enabled (typeof (FirefoxPlugin), false);
+            throw new ThreadError.AGAIN ("Firefox Plugin init Search History thread failed, deactivating plugin");
+          }
+        }
+        catch (Error e)
+        {
+          warning ("%s".printf (e.message));
+          plugin.data_sink.set_plugin_enabled (typeof (FirefoxPlugin), false);
+          return dest_result_set.get_sorted_list ();
+        }
+
+        plugin.use_history = true;
+        plugin.search_using_canal = canal;
+        ResultSet? results = yield plugin.search (q);
+        dest_result_set.add_all (results);
+
+        return dest_result_set.get_sorted_list ();
+      }
+    }
+
+
+    /**
+     * Initialisation methods
+     */
+
+    static construct
+    {
+      firefox_root_dir = Path.build_filename (Environment.get_home_dir (), firefox_root_dir);
+      var dfs = DesktopFileService.get_default ();
+      firefox_app_info = dfs.get_desktop_files_for_exec (FirefoxCanal.FIREFOX.to_string ()).first ();
+      firefoxtrunk_app_info = dfs.get_desktop_files_for_exec (FirefoxCanal.FIREFOXTRUNK.to_string ()).first ();
+      register_plugin ();
+    }
+
+    construct
+    {
+      use_history = false;
+      refresh_action = new RefreshBookmarks (this, FirefoxCanal.FIREFOXALL);
+      history_action_firefox = new SearchHistory (this, FirefoxCanal.FIREFOX);
+      history_action_firefoxtrunk = new SearchHistory (this, FirefoxCanal.FIREFOXTRUNK);
+      firefox_profiles_paths = new Gee.ArrayList<string> ();
+
+      string firefox_path = Path.build_filename (firefox_root_dir, FirefoxCanal.FIREFOX.to_string ());
+      string firefox_trunk_path = Path.build_filename (firefox_root_dir, FirefoxCanal.FIREFOXTRUNK.to_string ());
+
+      if ((bool)(firefox_canal & FirefoxCanal.FIREFOX) && FileUtils.test (firefox_path, FileTest.IS_DIR))
+        firefox_profiles_paths.add (firefox_path);
+
+      if ((bool)(firefox_canal & FirefoxCanal.FIREFOXTRUNK) && FileUtils.test (firefox_trunk_path, FileTest.IS_DIR))
+        firefox_profiles_paths.add (firefox_trunk_path);
+    }
+
+    protected override void constructed ()
+    {
+      data_sink.plugin_reseted.connect (this.reset);
+    }
+
+    public static void register_plugin ()
+    {
+      if (Environment.find_program_in_path (FirefoxCanal.FIREFOX.to_string ()) != null)
+        firefox_canal |= FirefoxCanal.FIREFOX;
+      if (Environment.find_program_in_path (FirefoxCanal.FIREFOXTRUNK.to_string ()) != null)
+        firefox_canal |= FirefoxCanal.FIREFOXTRUNK;
+
+      PluginRegistry.get_default ().register_plugin (
+        typeof (FirefoxPlugin),
+        _("Firefox"),
+        _("Browse and open Firefox bookmarks and history"),
+        FirefoxCanal.FIREFOX.to_string (),
+        register_plugin,
+        (bool)firefox_canal,
+        _("Firefox is not installed")
+      );
+    }
+
+    public void activate ()
+    {
+      firefox_profiles = new Gee.ArrayList<FirefoxProfile?> ();
+
+      try
+      {
+        // This would freeze ui in direct run
+        Thread<void*> init = new Thread<void*>.try ("FirefoxPluginActivation", () => {
+          search_busy = true;
+          parse_profiles ();
+          parse_bookmarks ();
+          parse_histories ();
+          search_busy = false;
+          return null;
+        });
+
+        if (null == init)
+        {
+          warning ("Firefox Plugin failed to init, deactivating plugin");
+          data_sink.set_plugin_enabled (typeof (FirefoxPlugin), false);
+        }
+      }
+      catch (Error e)
+      {
+        warning ("%s".printf (e.message));
+      }
+    }
+
+    public void deactivate ()
+    {
+      firefox_profiles = null;
+    }
+
+
+    /**
+     * Behaviors methods
+     */
+
+    public void reset ()
+    {
+      use_history = false;
+      search_using_canal = FirefoxCanal.FIREFOXALL;
+    }
+
+    public bool handles_unknown ()
+    {
+      return true;
+    }
+
+    public bool handles_query (Query query)
+    {
+      return (QueryFlags.INTERNET in query.query_type);
+    }
+
+
+    /**
+     * Search related methods
+     */
+
+    public async ResultSet? search (Query q) throws SearchError
+    {
+      bool search_cancelled = false;
+
+      var results = new ResultSet ();
+
+      try
+      {
+        uint state_signal_id = last_registered_signal_id = Idle.add_full (Priority.DEFAULT_IDLE, search.callback);
+        yield;
+
+        // Cancel if not the most recent search
+        if (state_signal_id != last_registered_signal_id)
+          throw new SearchError.SEARCH_CANCELLED ("Cancelled");
+
+        search_busy = true;
+
+        var matchers = Query.get_matchers_for_query (q.query_string, MatcherFlags.NO_FUZZY,  RegexCompileFlags.OPTIMIZE | RegexCompileFlags.CASELESS);
+
+        // This would freeze ui in direct run
+        Thread<void*> init = new Thread<void*>.try ("FirefoxPluginSearchThread", () => {
+          try
+          {
+            foreach (var matcher in matchers)
+            {
+              foreach (var profile in firefox_profiles)
+              {
+                // Use only Default profiles and Search match canal
+                if (profile.is_default && (bool)(search_using_canal & profile.type))
+                {
+                  if (use_history)
+                  {
+                    foreach (var history_entry in profile.history.entries)
+                    {
+                      q.check_cancellable ();
+
+                      // drop search for newerone
+                      if (state_signal_id  != last_registered_signal_id)
+                        throw new SearchError.SEARCH_CANCELLED ("Cancelled");
+
+                      // search titles only for performance sakes
+                      if (matcher.key.match (history_entry.value.title))
+                        results.add (history_entry.value, matcher.value);
+                    }
+                  }
+                  else
+                  {
+                    foreach (var bookmark in profile.bookmarks.entries)
+                    {
+                      q.check_cancellable ();
+
+                      // drop search for newerone
+                      if (state_signal_id != last_registered_signal_id)
+                        throw new SearchError.SEARCH_CANCELLED ("Cancelled");
+
+                      // title search
+                      if (matcher.key.match (bookmark.value.title))
+                      {
+                        results.add (bookmark.value, matcher.value);
+                        continue;
+                      }
+
+                      // uri search
+                      if (matcher.key.match (get_fqdn (bookmark.value.uri)))
+                        results.add (bookmark.value, matcher.value-MatchScore.INCREMENT_MINOR);
+                    }
+                  }
+                }
+              }
+            }
+          }
+          catch (SearchError e)
+          {
+            search_cancelled = true;
+          }
+          Idle.add (search.callback);
+          return null;
+        });
+
+        if (null == init)
+        {
+          warning ("Init search thread failed, deactivating plugin");
+          data_sink.set_plugin_enabled (typeof (FirefoxPlugin), false);
+        }
+        else
+          yield; // wait for thread to finish
+      }
+      catch (SearchError e)
+      {
+      }
+      catch (Error e)
+      {
+        warning ("%s".printf (e.message));
+      }
+
+      search_busy = false;
+
+      // honor cancelled search from Thread
+      if (search_cancelled)
+        throw new SearchError.SEARCH_CANCELLED ("Cancelled");
+
+      return results;
+    }
+
+    public ResultSet? find_for_match (ref Query q, Match match)
+    {
+      if (0 == (q.query_type & QueryFlags.INTERNET) || !(match is UnknownMatch))
+        return null;
+      var results = new ResultSet ();
+      results.add (refresh_action, refresh_action.default_relevancy);
+      if ((bool)firefox_canal & history_action_firefox.canal)
+        results.add (history_action_firefox, history_action_firefox.default_relevancy);
+      if ((bool)firefox_canal & history_action_firefox.canal)
+        results.add (history_action_firefoxtrunk, history_action_firefoxtrunk.default_relevancy);
+      return results;
+    }
+
+
+    /**
+     * Private methods
+     */
+
+    private void parse_profiles ()
+    {
+      foreach (string profile_path in firefox_profiles_paths)
+      {
+        if (FileUtils.test (profile_path, FileTest.EXISTS))
+        {
+          try
+          {
+            KeyFile file = new KeyFile ();
+            file.set_list_separator ('\n');
+            file.load_from_file (Path.build_filename (profile_path, "profiles.ini"), KeyFileFlags.NONE);
+
+            foreach (string group in file.get_groups ())
+            {
+              if ("general" == group.down ())
+                continue;
+
+              string name = file.get_string (group, "Name");
+              string _path = file.get_string (group, "Path");
+              bool _is_default = false;
+
+              if ("1" == file.get_string (group, "IsRelative"))
+                _path = Path.build_filename (profile_path, _path);
+
+              if (!FileUtils.test (_path, FileTest.EXISTS))
+              {
+                warning ("Profile '%s' was not found at %s".printf (name, _path));
+                continue;
+              }
+
+              if (file.has_key (group, "Default"))
+                _is_default = "1" == file.get_string (group, "Default") ? true : false;
+
+              firefox_profiles.add (FirefoxProfile ()
+              {
+                name = file.get_string (group, "Name"),
+                path = _path,
+                is_default = _is_default,
+                type = firefox_canal.from_string (Path.get_basename (profile_path)),
+                bookmarks = new Gee.HashMap<string, BookmarkMatch> (),
+                history = new Gee.HashMap<string, HistoryMatch> ()
+              });
+            }
+          }
+          catch (Error e)
+          {
+            warning ("%s".printf (e.message));
+          }
+        }
+      }
+    }
+
+    /**
+     * Send queries to DB
+     */
+    private Sqlite.Statement query_places (string query, string profile_path) throws ProfileParseError
+    {
+      string places_sqlite = Path.build_filename (profile_path, "places.sqlite");
+
+      if (!FileUtils.test (profile_path, FileTest.EXISTS))
+        throw new ProfileParseError.ERROR ("Profile folder not found at %s".printf (profile_path));
+      if (!FileUtils.test (places_sqlite, FileTest.EXISTS))
+        throw new ProfileParseError.ERROR ("Profile places database not found at %s".printf (places_sqlite));
+
+      Sqlite.Database db;
+      Sqlite.Statement stmt;
+
+      int ec = Sqlite.Database.open_v2 (places_sqlite, out db, Sqlite.OPEN_READONLY);
+      if (ec != Sqlite.OK)
+        throw new ProfileParseError.ERROR ("Can't open database: %d: %s\n", db.errcode (), db.errmsg ());
+
+      ec = db.prepare_v2 (query, query.length, out stmt);
+      if (ec != Sqlite.OK)
+        throw new ProfileParseError.ERROR ("Error: %d: %s\n", db.errcode (), db.errmsg ());
+
+      return stmt;
+    }
+
+    private void get_data_from_profiles_db (Type match_type, string query)
+    {
+      foreach (var profile in firefox_profiles)
+      {
+        try
+        {
+          var stmt = query_places (query, profile.path);
+          while (stmt.step () == Sqlite.ROW)
+          {
+            var title = stmt.column_text (0) ?? null;
+            var url = stmt.column_text (1) ?? null;
+
+            // if we can't display no use, then dismiss
+            if (null == title || null == url)
+              continue;
+
+            if (match_type == typeof (BookmarkMatch))
+            {
+              if (!profile.bookmarks.has_key (url))
+                profile.bookmarks.set (url, new BookmarkMatch (title, url));
+            }
+            else if (!profile.history.has_key (url))
+                profile.history.set (url, new HistoryMatch (title, url));
+          }
+        }
+        catch (ProfileParseError e)
+        {
+          message ("%s : %s".printf (profile.name, e.message));
+        }
+      }
+    }
+
+    private void parse_bookmarks ()
+    {
+      string query = """
+        SELECT b.title, h.url
+        FROM moz_places h
+        JOIN moz_bookmarks b ON h.id = b.fk
+        WHERE b.title != ""
+        AND h.url != ""
+        AND h.url NOT LIKE "place:%"
+        AND h.url NOT LIKE "source:%"
+        AND h.url NOT LIKE "css:%"
+        AND h.url NOT LIKE "data:%"
+        AND h.url NOT LIKE "file:%"
+        AND h.url NOT LIKE "javascript:%";""";
+
+        get_data_from_profiles_db (typeof (BookmarkMatch), query);
+    }
+
+    private void parse_histories ()
+    {
+      string query = """
+        SELECT h.title, h.url
+        FROM moz_places h
+        JOIN moz_historyvisits b ON h.id = b.place_id
+        WHERE h.title != ""
+        AND h.url != ""
+        AND h.url NOT LIKE "place:%"
+        AND h.url NOT LIKE "source:%"
+        AND h.url NOT LIKE "css:%"
+        AND h.url NOT LIKE "data:%"
+        AND h.url NOT LIKE "file:%"
+        AND h.url NOT LIKE "javascript:%";""";
+
+        get_data_from_profiles_db (typeof (HistoryMatch), query);
+    }
+
+    private string get_fqdn (string uri)
+    {
+      string _uri = Utils.replace_first_occurence (uri, Uri.parse_scheme (uri) + "://");
+      _uri = Utils.replace_first_occurence (_uri, "www.");
+      int slash_index = _uri.index_of_char ('/');
+      return -1 != slash_index ? _uri.slice (0, slash_index) : _uri;
+    }
+  }
+}

=== modified file 'src/ui/controller.vala'
--- src/ui/controller.vala	2015-11-30 14:44:16 +0000
+++ src/ui/controller.vala	2015-12-02 20:28:49 +0000
@@ -177,6 +177,11 @@
       this.view.summon_or_vanish ();
     }
 
+    public void view_is_hidden ()
+    {
+      data_sink.reset_plugins ();
+    }
+
     /* End interface implementation */
     protected Gtk.IMMulticontext im_context;
 

=== modified file 'src/ui/synapse-main.vala'
--- src/ui/synapse-main.vala	2015-10-05 07:03:23 +0000
+++ src/ui/synapse-main.vala	2015-12-02 20:28:49 +0000
@@ -176,6 +176,7 @@
         typeof (SshPlugin),
         typeof (XnoiseActions),
         typeof (ChromiumPlugin),
+        typeof (FirefoxPlugin),
         typeof (FileOpPlugin),
         typeof (PidginPlugin),
         typeof (ChatActions),

=== modified file 'src/ui/view-base.vala'
--- src/ui/view-base.vala	2015-11-16 10:25:05 +0000
+++ src/ui/view-base.vala	2015-12-02 20:28:49 +0000
@@ -448,6 +448,7 @@
       this.hide ();
       this.vanished ();
       IconCacheService.get_default ().reduce_cache ();
+      ((Gui.Controller)controller).view_is_hidden ();
     }
 
     public virtual void summon_or_vanish ()