Code review comment for lp:~jeremy-munsch/synapse-project/ascii-smart

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

Looks pretty bold and changes the internal behavior quite a lot.

There are for sure some avoidable performances issue, like useless string-copying.
(Better usage of const, unowned strings and GLib.HashTables)

What I am most curious about is the "reverse" stuff.
If the user explicitly searches for it should there be not-closely-matching results?
Should "additional" results be weighted lower?

review: Needs Information

« Back to merge proposal