Merge lp:~jens-erat/moderncv/moderncv into lp:moderncv

Proposed by Jens Erat
Status: Needs review
Proposed branch: lp:~jens-erat/moderncv/moderncv
Merge into: lp:moderncv
Diff against target: 104 lines (+46/-1)
4 files modified
moderncv.cls (+3/-1)
moderncviconsawesome.sty (+22/-0)
moderncviconsletters.sty (+1/-0)
moderncviconsmarvosym.sty (+20/-0)
To merge this branch: bzr merge lp:~jens-erat/moderncv/moderncv
Reviewer Review Type Date Requested Status
Xavier Danaux Pending
Review via email: mp+174629@code.launchpad.net

Description of the change

While the awesome font already has an icon for Stack Overflow, it wasn't merged to CTAN yet, so I used the same Tikz code like in the markosym version. Including the other Stack Exchange sites would be easy if we'd have a b/w version of their logos, for Stack Overflow I could use the Meta icon which already is...

I did _not_ create an URL which includes the user name, as Stack Overflow uses a User ID in the user site. If no URL is given, it defaults to the main page instead.

To post a comment you must log in.

Unmerged revisions

136. By Jens Erat <email address hidden>

Added Stack Overflow social account

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'moderncv.cls'
2--- moderncv.cls 2013-04-29 17:45:09 +0000
3+++ moderncv.cls 2013-07-14 20:17:25 +0000
4@@ -249,7 +249,7 @@
5
6 % adds a social link to one's personal information (optional)
7 % usage: \social[<optional type>][<optional url>]{<account name>}
8-% where <optional type> should be either "linkedin", "twitter" or "github"
9+% where <optional type> should be either "linkedin", "twitter", "github" or "stackoverflow"
10 \collectionnew{socials}
11 \NewDocumentCommand{\social}{O{}O{}m}{%
12 \ifthenelse{\equal{#2}{}}%
13@@ -257,6 +257,7 @@
14 \ifthenelse{\equal{#1}{linkedin}}{\collectionadd[linkedin]{socials}{\protect\httplink[#3]{www.linkedin.com/in/#3}}}{}%
15 \ifthenelse{\equal{#1}{twitter}} {\collectionadd[twitter]{socials} {\protect\httplink[#3]{www.twitter.com/#3}}} {}%
16 \ifthenelse{\equal{#1}{github}} {\collectionadd[github]{socials} {\protect\httplink[#3]{www.github.com/#3}}} {}%
17+ \ifthenelse{\equal{#1}{stackoverflow}}{\collectionadd[stackoverflow]{socials}{\protect\httplink[#3]{www.stackoverflow.com}}}{}%
18 }
19 {\collectionadd[#1]{socials}{\protect\httplink[#3]{#2}}}}
20
21@@ -296,6 +297,7 @@
22 \newcommand*{\linkedinsocialsymbol}{}
23 \newcommand*{\twittersocialsymbol} {}
24 \newcommand*{\githubsocialsymbol} {}
25+\newcommand*{\stackoverflowsocialsymbol}{}
26
27 % other
28 %------
29
30=== modified file 'moderncviconsawesome.sty'
31--- moderncviconsawesome.sty 2013-04-29 17:45:09 +0000
32+++ moderncviconsawesome.sty 2013-07-14 20:17:25 +0000
33@@ -38,6 +38,28 @@
34 \renewcommand*{\linkedinsocialsymbol}{\faLinkedinSign~} % alternative: \faLinkedin
35 \renewcommand*{\twittersocialsymbol} {\faTwitter~}
36 \renewcommand*{\githubsocialsymbol} {\faGithub~}
37+\renewcommand*{\stackoverflowsocialsymbol}{%
38+ \protect\raisebox{0em}{%
39+ \protect\begin{tikzpicture}[y=0.08em,x=0.08em, xscale=0.2, yscale=-0.2, inner sep=0pt, outer sep=0pt]
40+ \protect\path[fill=color2] (8.2067,36.9635) -- (12.6080,37.0067) -- (12.4545,56.6051)
41+ -- (41.7458,56.6051) -- (41.7458,37.0776) -- (46.3836,37.0776) --
42+ (46.3836,61.3649) -- (8.1829,61.3649) -- (8.2067,36.9636) -- cycle;
43+ \protect\path[fill=color2,rounded corners=0.0000cm] (15.3837,48.5500) rectangle
44+ (38.3285,53.4319);
45+ \protect\path[cm={{0.99537,0.09607,-0.09607,0.99537,(0.0,0.0)}},fill=color2,rounded
46+ corners=0.0000cm] (19.6679,38.0512) rectangle (42.7347,43.0551);
47+ \protect\path[cm={{0.9624,0.27163,-0.27163,0.9624,(0.0,0.0)}},fill=color2,rounded
48+ corners=0.0000cm] (25.4470,23.8114) rectangle (48.5139,28.8154);
49+ \protect\path[cm={{0.85598,0.51701,-0.51701,0.85598,(0.0,0.0)}},fill=color2,rounded
50+ corners=0.0000cm] (29.6486,3.8206) rectangle (52.7155,8.8246);
51+ \protect\path[cm={{0.58243,0.81288,-0.81288,0.58243,(0.0,0.0)}},fill=color2,rounded
52+ corners=0.0000cm] (26.6464,-23.5147) rectangle (49.7133,-18.5108);
53+ \protect\path[cm={{0.16481,0.98633,-0.98633,0.16481,(0.0,0.0)}},fill=color2,rounded
54+ corners=0.0000cm] (11.1079,-49.0813) rectangle (34.1748,-44.0774);
55+ \protect\end{tikzpicture}}%
56+ ~}
57+
58+
59
60
61 % if XeTeX or LuaTeX is not used, load the marvosym icon set instead
62
63=== modified file 'moderncviconsletters.sty'
64--- moderncviconsletters.sty 2013-04-29 17:45:09 +0000
65+++ moderncviconsletters.sty 2013-07-14 20:17:25 +0000
66@@ -43,6 +43,7 @@
67 \renewcommand*{\linkedinsocialsymbol}{\hbox to 1.1em{\textbf{in}}~}
68 \renewcommand*{\twittersocialsymbol} {\hbox to 1.1em{\textbf{tw}}~}
69 \renewcommand*{\githubsocialsymbol} {\hbox to 1.1em{\textbf{gh}}~}
70+\renewcommand*{\stackoverflowsocialsymbol}{\hbox to 1.1em{\textbf{so}}~}
71
72 \renewcommand*{\listitemsymbol} {\labelitemi~}
73
74
75=== modified file 'moderncviconsmarvosym.sty'
76--- moderncviconsmarvosym.sty 2013-04-29 17:45:09 +0000
77+++ moderncviconsmarvosym.sty 2013-07-14 20:17:25 +0000
78@@ -222,6 +222,26 @@
79 \protect\end{scope}%
80 \protect\end{tikzpicture}}%
81 ~}
82+\renewcommand*{\stackoverflowsocialsymbol}{%
83+ \protect\raisebox{0em}{%
84+ \protect\begin{tikzpicture}[y=0.08em,x=0.08em, xscale=0.2, yscale=-0.2, inner sep=0pt, outer sep=0pt]
85+ \protect\path[fill=color2] (8.2067,36.9635) -- (12.6080,37.0067) -- (12.4545,56.6051)
86+ -- (41.7458,56.6051) -- (41.7458,37.0776) -- (46.3836,37.0776) --
87+ (46.3836,61.3649) -- (8.1829,61.3649) -- (8.2067,36.9636) -- cycle;
88+ \protect\path[fill=color2,rounded corners=0.0000cm] (15.3837,48.5500) rectangle
89+ (38.3285,53.4319);
90+ \protect\path[cm={{0.99537,0.09607,-0.09607,0.99537,(0.0,0.0)}},fill=color2,rounded
91+ corners=0.0000cm] (19.6679,38.0512) rectangle (42.7347,43.0551);
92+ \protect\path[cm={{0.9624,0.27163,-0.27163,0.9624,(0.0,0.0)}},fill=color2,rounded
93+ corners=0.0000cm] (25.4470,23.8114) rectangle (48.5139,28.8154);
94+ \protect\path[cm={{0.85598,0.51701,-0.51701,0.85598,(0.0,0.0)}},fill=color2,rounded
95+ corners=0.0000cm] (29.6486,3.8206) rectangle (52.7155,8.8246);
96+ \protect\path[cm={{0.58243,0.81288,-0.81288,0.58243,(0.0,0.0)}},fill=color2,rounded
97+ corners=0.0000cm] (26.6464,-23.5147) rectangle (49.7133,-18.5108);
98+ \protect\path[cm={{0.16481,0.98633,-0.98633,0.16481,(0.0,0.0)}},fill=color2,rounded
99+ corners=0.0000cm] (11.1079,-49.0813) rectangle (34.1748,-44.0774);
100+ \protect\end{tikzpicture}}%
101+ ~}
102
103
104 \endinput

Subscribers

People subscribed via source and target branches

to all changes: