Merge lp:~jelmer/ubuntu/natty/evolution-mapi/513394-recurring-events into lp:ubuntu/natty/evolution-mapi

Proposed by Jelmer Vernooij
Status: Merged
Merged at revision: 15
Proposed branch: lp:~jelmer/ubuntu/natty/evolution-mapi/513394-recurring-events
Merge into: lp:ubuntu/natty/evolution-mapi
Diff against target: 99 lines (+70/-0)
4 files modified
debian/changelog (+8/-0)
debian/control (+1/-0)
debian/patches/02_recurring_events (+60/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~jelmer/ubuntu/natty/evolution-mapi/513394-recurring-events
Reviewer Review Type Date Requested Status
Chuck Short (community) code Approve
Ubuntu branches Pending
Review via email: mp+49485@code.launchpad.net

Description of the change

Cherry pick the upstream changes to fix bug 513394.

Add "Enhances: evolution" to the evolution-mapi package, so it shows up as an "Add-on" in the software center.

To post a comment you must log in.
16. By Jelmer Vernooij

Add patch header.

17. By Jelmer Vernooij

use my ubuntu credentials.

Revision history for this message
Chuck Short (zulcss) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-02-01 13:07:04 +0000
3+++ debian/changelog 2011-02-12 00:51:29 +0000
4@@ -1,3 +1,11 @@
5+evolution-mapi (0.32.1-0ubuntu2) natty; urgency=low
6+
7+ * Add patch 02_recurring_events: fix recurring events not showing from
8+ Exchange 2007. LP: #513394
9+ * Add 'Enhances: evolution' for evolution-mapi.
10+
11+ -- Jelmer Vernooij <jelmer@ubuntu.com> Sat, 12 Feb 2011 00:49:53 +0100
12+
13 evolution-mapi (0.32.1-0ubuntu1) natty; urgency=low
14
15 * New upstream release.
16
17=== modified file 'debian/control'
18--- debian/control 2011-02-01 13:07:04 +0000
19+++ debian/control 2011-02-12 00:51:29 +0000
20@@ -41,6 +41,7 @@
21 ${misc:Depends},
22 evolution (>= 2.32),
23 evolution (<< 2.33)
24+Enhances: evolution
25 Description: Exchange support for the Evolution groupware suite
26 The Evolution MAPI provider adds support for Microsoft Exchange,
27 including Exchange 2007, to the Evolution groupware suite, using the
28
29=== added file 'debian/patches/02_recurring_events'
30--- debian/patches/02_recurring_events 1970-01-01 00:00:00 +0000
31+++ debian/patches/02_recurring_events 2011-02-12 00:51:29 +0000
32@@ -0,0 +1,60 @@
33+Description: Cherry-pick of fix for recurring events, Ubuntu bug 513394
34+Origin: upstream, commit: f36cca5d32ce87a53684d950d53da75e266553ff,
35+ commit:fc48cc0ae6f74f9ca292969fa034da6c48f1e6ef
36+Bug: https://bugzilla.gnome.org/show_bug.cgi?id=604029
37+Author: Milan Crha <mcrha@redhat.com>, Sean Finney <seanius@seanius.net>
38+
39+=== modified file 'src/libexchangemapi/exchange-mapi-cal-recur-utils.c'
40+--- old/src/libexchangemapi/exchange-mapi-cal-recur-utils.c 2010-10-19 15:03:33 +0000
41++++ new/src/libexchangemapi/exchange-mapi-cal-recur-utils.c 2011-02-11 23:36:57 +0000
42+@@ -656,8 +656,10 @@
43+ /* some constant */
44+ flag32 = *((guint32 *)ptr);
45+ ptr += sizeof (guint32);
46++ /* It should be set, but not must. It can be, technically, any value.
47++ Seen were 0x3006, 0x3008, 0x3009. It affects format of extended exception info
48+ if (flag32 != WRITER_VERSION2)
49+- return FALSE;
50++ return FALSE; */
51+
52+ /* start time in mins */
53+ flag32 = *((guint32 *)ptr);
54+@@ -670,20 +672,11 @@
55+ /* modified exceptions */
56+ flag16 = *((guint16 *)ptr);
57+ ptr += sizeof (guint16);
58+- if (flag16 != 0x0)
59+- return FALSE;
60+-
61+- /* reserved block1 size - has to be 0 */
62+- flag32 = *((guint32 *)ptr);
63+- ptr += sizeof (guint32);
64+- if (flag32 != 0x0)
65+- return FALSE;
66+-
67+- /* reserved block2 size - has to be 0 */
68+- flag32 = *((guint32 *)ptr);
69+- ptr += sizeof (guint32);
70+- if (flag32 != 0x0)
71+- return FALSE;
72++ /* FIXME: there are flag16 count modified exceptions here, which
73++ are variable in size, followed by a ReservedBlock1{Size,}
74++ and ReservedBlock2{Size,}. However, since we have nothing
75++ else to do until we are able to parse these modified
76++ instances, we just stop now. */
77+
78+ /* Set the recurrence */
79+ {
80+@@ -698,11 +691,6 @@
81+ /* FIXME: this also has modified instances */
82+ e_cal_component_set_exdate_list (comp, exdate_list);
83+
84+- g_print ("\n== MAPI to ICAL == The recurrence blob data is as follows:\n");
85+- for (i = 0; i < ba->len; ++i)
86+- g_print ("0x%02X ", ba->data[i]);
87+- g_print("\n== End of stream ==\n");
88+-
89+ return TRUE;
90+ }
91+
92+
93
94=== modified file 'debian/patches/series'
95--- debian/patches/series 2011-02-01 13:07:04 +0000
96+++ debian/patches/series 2011-02-12 00:51:29 +0000
97@@ -1,1 +1,2 @@
98 01_openchange_compat
99+02_recurring_events

Subscribers

People subscribed via source and target branches