Merge ~jelmer/ubuntu/+source/evolution-indicator:lintian-fixes into ubuntu/+source/evolution-indicator:ubuntu/devel

Proposed by Jelmer Vernooij
Status: Rejected
Rejected by: Robie Basak
Proposed branch: ~jelmer/ubuntu/+source/evolution-indicator:lintian-fixes
Merge into: ubuntu/+source/evolution-indicator:ubuntu/devel
Diff against target: 174 lines (+32/-22)
5 files modified
debian/changelog (+23/-12)
debian/control (+5/-6)
debian/copyright (+1/-1)
debian/rules (+2/-2)
debian/watch (+1/-1)
Reviewer Review Type Date Requested Status
Ubuntu Sponsors Pending
git-ubuntu developers Pending
Review via email: mp+361993@code.launchpad.net

Description of the change

Fix some issues reported by lintian
* Use correct machine-readable copyright file URI.
* Use secure URI in Vcs control header.
* Trim trailing whitespace.
* Drop unnecessary dependency on dh-autoconf.
* Use secure URI in debian/watch.
* Change priority extra to priority optional.

To post a comment you must log in.
Revision history for this message
Robie Basak (racb) wrote :

Thank you for contributing these changes.

Please note that we don't yet have a process for arranging general sponsorship for MPs submitted through git-ubuntu. As these changes are so trivial, I don't think it's worth me spending time on arranging this right now.

Ideally these would appear in http://reqorts.qa.ubuntu.com/reports/sponsoring/index.html but they currently do not.

A contribution to adjust that report would be welcome.

Alternatively you could file a bug, subscribe ~ubuntu-sponsors and link this MP to it.

Until then I suspect this MP won't get looked at. Sorry!

Revision history for this message
Robie Basak (racb) wrote :

Closing, since this MP isn't actionable as-is - see previous comment.

Unmerged commits

9e386f4... by Jelmer Vernooij

Change priority extra to priority optional.

Fixes lintian: priority-extra-is-replaced-by-priority-optional
See https://lintian.debian.org/tags/priority-extra-is-replaced-by-priority-optional.html for more details.

a291394... by Jelmer Vernooij

Use secure URI in debian/watch.

Fixes lintian: debian-watch-uses-insecure-uri
See https://lintian.debian.org/tags/debian-watch-uses-insecure-uri.html for more details.

6f554be... by Jelmer Vernooij

Drop unnecessary dependency on dh-autoconf.

Fixes lintian: useless-autoreconf-build-depends
See https://lintian.debian.org/tags/useless-autoreconf-build-depends.html for more details.

1623ee2... by Jelmer Vernooij

Trim trailing whitespace.

Fixes lintian: file-contains-trailing-whitespace
See https://lintian.debian.org/tags/file-contains-trailing-whitespace.html for more details.

1e353b5... by Jelmer Vernooij

Use secure URI in Vcs control header.

Fixes lintian: vcs-field-uses-insecure-uri
See https://lintian.debian.org/tags/vcs-field-uses-insecure-uri.html for more details.

aa46de7... by Jelmer Vernooij

Use correct machine-readable copyright file URI.
Fixed-Lintian-Tag: out-of-date-copyright-format

fddbdd5... by Jeremy Bícha

Import patches-unapplied version 0.2.20-0ubuntu36 to ubuntu/cosmic-proposed

Imported using git-ubuntu import.

Changelog parent: 6eb9b92c3d5d5c918a809f8343f65f5d26f8d6e2

New changelog entries:
  * No-change rebuild against latest evolution

6eb9b92... by Jeremy Bícha

Import patches-unapplied version 0.2.20-0ubuntu35 to ubuntu/cosmic-proposed

Imported using git-ubuntu import.

Changelog parent: 2ba1994494dc023ae2d177ca0c395438e5806e4b

New changelog entries:
  * No-change rebuild against latest evolution

2ba1994... by Ken VanDine

Import patches-unapplied version 0.2.20-0ubuntu34 to ubuntu/cosmic-proposed

Imported using git-ubuntu import.

Changelog parent: 13882a5f50ea2c96c6438eb620b29f7e192fa0cb

New changelog entries:
  * debian/patches/desktop_file_rename.patch
    - Handle desktop file rename to org.gnome.Evolution.desktop (LP: #1778544)

13882a5... by Jeremy Bícha

Import patches-unapplied version 0.2.20-0ubuntu33 to ubuntu/bionic-proposed

Imported using git-ubuntu import.

Changelog parent: cd95340a35859c5d6a3ad16f0afbf5f7a97cb8dc

New changelog entries:
  * No-change rebuild against latest evolution

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index eec5333..f93ec01 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,14 @@
6+evolution-indicator (0.2.20-0ubuntu37) UNRELEASED; urgency=medium
7+
8+ * Use correct machine-readable copyright file URI.
9+ * Use secure URI in Vcs control header.
10+ * Trim trailing whitespace.
11+ * Drop unnecessary dependency on dh-autoconf.
12+ * Use secure URI in debian/watch.
13+ * Change priority extra to priority optional.
14+
15+ -- Jelmer Vernooij <jelmer@debian.org> Sat, 19 Jan 2019 02:56:58 +0000
16+
17 evolution-indicator (0.2.20-0ubuntu36) cosmic; urgency=medium
18
19 * No-change rebuild against latest evolution
20@@ -82,7 +93,7 @@ evolution-indicator (0.2.20-0ubuntu24) yakkety; urgency=medium
21 evolution-indicator (0.2.20-0ubuntu22) xenial; urgency=medium
22
23 * debian/control,
24- debian/patches/gtkhtml_is_deprecated.patch: don't use gtkhtml
25+ debian/patches/gtkhtml_is_deprecated.patch: don't use gtkhtml
26 it's deprecated and not used by the current evolution version
27
28 -- Sebastien Bacher <seb128@ubuntu.com> Tue, 15 Dec 2015 11:11:59 +0100
29@@ -127,11 +138,11 @@ evolution-indicator (0.2.20-0ubuntu15) trusty; urgency=medium
30 evolution-indicator (0.2.20-0ubuntu13) trusty; urgency=medium
31
32 * debian/patches/evolution-indicator-eds3.6_v2.patch:
33- - use correct GList type, should fix segfault issues,
34+ - use correct GList type, should fix segfault issues,
35 thanks Xavier Claessens (lp: #1194005)
36
37 [ Iain Lane ]
38- * Build-Depend on evolution 3.10
39+ * Build-Depend on evolution 3.10
40
41 -- Sebastien Bacher <seb128@ubuntu.com> Mon, 03 Feb 2014 16:28:00 +0000
42
43@@ -179,7 +190,7 @@ evolution-indicator (0.2.20-0ubuntu9) raring; urgency=low
44 evolution-indicator (0.2.20-0ubuntu8) quantal; urgency=low
45
46 * debian/control
47- - added build depends for libebackend1.2-dev, libcamel1.2-dev, and
48+ - added build depends for libebackend1.2-dev, libcamel1.2-dev, and
49 libsoup2.4-dev
50 - bumped build depends for evolution-dev to >= 3.4
51 * debian/patches/02_evo_3_4_build_fixes.patch
52@@ -219,7 +230,7 @@ evolution-indicator (0.2.20-0ubuntu5) precise; urgency=low
53 evolution-indicator (0.2.20-0ubuntu4) precise; urgency=low
54
55 * debian/control
56- - depend on evolution so evolution-indicator will get removed if
57+ - depend on evolution so evolution-indicator will get removed if
58 evolution is uninstalled (LP: #663988)
59
60 -- Ken VanDine <ken.vandine@canonical.com> Tue, 13 Dec 2011 09:59:18 -0500
61@@ -238,7 +249,7 @@ evolution-indicator (0.2.20-0ubuntu2) oneiric; urgency=low
62
63 evolution-indicator (0.2.20-0ubuntu1) oneiric; urgency=low
64
65- * New upstream release, fix an untranslatable string bug
66+ * New upstream release, fix an untranslatable string bug
67 (lp: #437963)
68
69 -- Sebastien Bacher <seb128@ubuntu.com> Fri, 09 Sep 2011 11:27:29 +0200
70@@ -292,7 +303,7 @@ evolution-indicator (0.2.14-0ubuntu2) natty; urgency=low
71 * src/evolution-indicator.c
72 - Added unread counter to the unity launcher
73 * src/evolution-indicator.c
74- - simplify and fix handling POP accounts. Setting a POP account to IMAP
75+ - simplify and fix handling POP accounts. Setting a POP account to IMAP
76 and back to POP would cause evolution to crash (LP: #643321)
77
78 -- Ken VanDine <ken.vandine@canonical.com> Thu, 24 Feb 2011 00:04:38 -0500
79@@ -365,7 +376,7 @@ evolution-indicator (0.2.6-0ubuntu2) lucid; urgency=low
80
81 evolution-indicator (0.2.6-0ubuntu1) lucid; urgency=low
82
83- * New upstream version
84+ * New upstream version
85
86 -- Sebastien Bacher <seb128@ubuntu.com> Thu, 21 Jan 2010 22:21:09 +0100
87
88@@ -380,7 +391,7 @@ evolution-indicator (0.2.4-0ubuntu5) lucid; urgency=low
89
90 * debian/rules:
91 - use the upstream evolution desktop entry there
92-
93+
94 [ Ken VanDine ]
95 * debian/preinst:
96 - fixed the version compare to be friendly on new installs
97@@ -403,10 +414,10 @@ evolution-indicator (0.2.4-0ubuntu3) karmic-proposed; urgency=low
98
99 evolution-indicator (0.2.4-0ubuntu2) karmic; urgency=low
100
101- * debian/rules:
102- - Moved the indicator launcher to /usr/share (LP: #434097)
103+ * debian/rules:
104+ - Moved the indicator launcher to /usr/share (LP: #434097)
105 * debian/postinst:
106- - remove the old indicator from /etc and remove the directory
107+ - remove the old indicator from /etc and remove the directory
108 if it is empty
109
110 -- Ken VanDine <ken.vandine@canonical.com> Thu, 24 Sep 2009 15:14:30 -0400
111diff --git a/debian/control b/debian/control
112index dd0e1fc..e7e1edb 100644
113--- a/debian/control
114+++ b/debian/control
115@@ -1,9 +1,9 @@
116 Source: evolution-indicator
117 Section: gnome
118-Priority: extra
119+Priority: optional
120 Maintainer: Ubuntu Core Developers <ubuntu-devel-discuss@lists.ubuntu.com>
121-Build-Depends: debhelper (>= 9),
122- autotools-dev,
123+Build-Depends: debhelper (>= 10),
124+ autotools-dev,
125 gnome-pkg-tools (>= 0.10),
126 libglib2.0-dev (>= 2.15.5),
127 libpango1.0-dev (>= 1.18.0),
128@@ -22,12 +22,11 @@ Build-Depends: debhelper (>= 9),
129 libcamel1.2-dev (>= 3.4),
130 libsoup2.4-dev,
131 libunity-dev (>= 5.0.0),
132- libmessaging-menu-dev,
133- dh-autoreconf
134+ libmessaging-menu-dev
135 Standards-Version: 3.9.4
136 Homepage: https://launchpad.net/evolution-indicator
137 X-Ubuntu-Use-Langpack: yes
138-Vcs-Bzr: http://bazaar.launchpad.net/~ubuntu-desktop/evolution-indicator/ubuntu
139+Vcs-Bzr: https://code.launchpad.net/~ubuntu-desktop/evolution-indicator/ubuntu
140
141 Package: evolution-indicator
142 Architecture: any
143diff --git a/debian/copyright b/debian/copyright
144index d478b4a..3447e48 100644
145--- a/debian/copyright
146+++ b/debian/copyright
147@@ -1,4 +1,4 @@
148-Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
149+Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
150 Upstream-Name: evolution-indicator
151 Upstream-Contact: Canonical Ltd.
152 Source: http://launchpad.net/evolution-indicator
153diff --git a/debian/rules b/debian/rules
154index 5911fdb..b4b6b6c 100755
155--- a/debian/rules
156+++ b/debian/rules
157@@ -1,7 +1,7 @@
158-#!/usr/bin/make -f
159+#!/usr/bin/make -f
160
161 %:
162- dh $@ --with autoreconf
163+ dh $@
164
165 override_dh_makeshlibs:
166 dh_makeshlibs -X*
167diff --git a/debian/watch b/debian/watch
168index 5a86de2..80eb957 100644
169--- a/debian/watch
170+++ b/debian/watch
171@@ -1,2 +1,2 @@
172 version=3
173-http://launchpad.net/evolution-indicator/+download .*/evolution-indicator-([0-9.]+)\.tar\.gz
174+https://launchpad.net/evolution-indicator/+download .*/evolution-indicator-([0-9.]+)\.tar\.gz

Subscribers

People subscribed via source and target branches