Merge ~jelmer/ubuntu/+source/android-headers:lintian-fixes into ubuntu/+source/android-headers:ubuntu/devel

Proposed by Jelmer Vernooij
Status: Rejected
Rejected by: Robie Basak
Proposed branch: ~jelmer/ubuntu/+source/android-headers:lintian-fixes
Merge into: ubuntu/+source/android-headers:ubuntu/devel
Diff against target: 60 lines (+15/-5)
5 files modified
debian/changelog (+10/-0)
debian/compat (+1/-1)
debian/control (+2/-2)
debian/copyright (+1/-1)
debian/rules (+1/-1)
Reviewer Review Type Date Requested Status
Ubuntu Sponsors Pending
git-ubuntu developers Pending
Review via email: mp+361991@code.launchpad.net

Description of the change

Fix some issues reported by lintian
* Bump debhelper from old 9 to 10.
* Use versioned copyright format URI.
* Change priority extra to priority optional.
* Don't specify --with=quilt, since package uses '3.0 (quilt)' source format.

To post a comment you must log in.
Revision history for this message
Robie Basak (racb) wrote :

Thank you for contributing these changes.

Please note that we don't yet have a process for arranging general sponsorship for MPs submitted through git-ubuntu. As these changes are so trivial, I don't think it's worth me spending time on arranging this right now.

Ideally these would appear in http://reqorts.qa.ubuntu.com/reports/sponsoring/index.html but they currently do not.

A contribution to adjust that report would be welcome.

Alternatively you could file a bug, subscribe ~ubuntu-sponsors and link this MP to it.

Until then I suspect this MP won't get looked at. Sorry!

Revision history for this message
Robie Basak (racb) wrote :

Closing, since this MP isn't actionable as-is - see previous comment.

Unmerged commits

16b5bc6... by Jelmer Vernooij

Don't specify --with=quilt, since package uses '3.0 (quilt)' source format.

Fixes lintian: dh-quilt-addon-but-quilt-source-format
See https://lintian.debian.org/tags/dh-quilt-addon-but-quilt-source-format.html for more details.

7fe05fd... by Jelmer Vernooij

Change priority extra to priority optional.

Fixes lintian: priority-extra-is-replaced-by-priority-optional
See https://lintian.debian.org/tags/priority-extra-is-replaced-by-priority-optional.html for more details.

6b7725a... by Jelmer Vernooij

Use versioned copyright format URI.

Fixes lintian: unversioned-copyright-format-uri
See https://lintian.debian.org/tags/unversioned-copyright-format-uri.html for more details.

f9a4d5f... by Jelmer Vernooij

Bump debhelper from old 9 to 10.

Fixes lintian: package-uses-old-debhelper-compat-version
See https://lintian.debian.org/tags/package-uses-old-debhelper-compat-version.html for more details.

b7d0302... by Simon Fels

Import patches-unapplied version 23-0ubuntu4 to ubuntu/yakkety-proposed

Imported using git-ubuntu import.

Changelog parent: d6f43004636adf9d19b3def95e5ca46a5a4cb64e

New changelog entries:
  [ You-Sheng Yang ]
  * android-19: hardware: align struct size on arm64

d6f4300... by Simon Fels

Import patches-unapplied version 23-0ubuntu3 to ubuntu/yakkety-proposed

Imported using git-ubuntu import.

Changelog parent: 472b165e930bbbd4e4d181445a4002e3468896f1

New changelog entries:
  * debian/control: add appropriate Pre-Depends on dpkg for mainscript
    helper.
  * debian/control: fix link to vcs
  * Patch 21-23 to fix ABI problems when we mix softfp and hardfp
    binaries (LP: #1548954). This was discovered while fixing a
    problem with the Android Audio HAL API.

472b165... by Chris Halse Rogers

Import patches-unapplied version 23-0ubuntu2 to ubuntu/xenial-proposed

Imported using git-ubuntu import.

Changelog parent: ab4f0e4947acad6978d7184f8e8ac5b4165bb9c4

New changelog entries:
  * debian/android-headers.{preinst,postinst,postrm}: Use
    dpkg-maintscript-helper to switch /usr/include/android to a symlink.
    (LP: #1539338)
  * debian/control: add appropriate Pre-Depends on dpkg for mainscript helper.

ab4f0e4... by Simon Fels

Import patches-unapplied version 23-0ubuntu1 to ubuntu/xenial-proposed

Imported using git-ubuntu import.

Changelog parent: da322b2078b19cd6f1b63b0d5c4466aa5d0996cc

New changelog entries:
  * New upstream release which now includes multiple sets of header files
    divided by the Android API levels we care about.
  * All header sets are now installed in their corresponding debian package
    android-headers-<API level>. The former android-headers package is now
    a transitional one depending on android-headers-19 and installing proper
    symlinks to allow all current users to still build without any changes.
  * Install proper pkgconfig configuration files for all header sets so that
    users can now select which of those to use a build time.
  [ Yuan-Chen Cheng ]
  * add android-config.h and vibrator.h required by new libhybris
  * catch up extract-headers.sh (not in released file list)

da322b2... by Ricardo Salveti

Import patches-unapplied version 4.4.2-2-0ubuntu4 to ubuntu/vivid-proposed

Imported using git-ubuntu import.

Changelog parent: 5563f66d921e4b24336e91ef1fd1e830635316b5

New changelog entries:
  * debian/patches/updating_hwcomposer_android5.patch:
    - Updating hwcomposer headers so we can use hwcomposer 1.4

5563f66... by Mathieu Trudel-Lapierre

Import patches-unapplied version 4.4.2-2-0ubuntu3 to ubuntu/vivid-proposed

Imported using git-ubuntu import.

Changelog parent: 70c09484d6cc430e5f27e894373bf9a36e1bd2dc

New changelog entries:
  * debian/patches/wifi_compat_check_avail.patch: add declaration for new
    method to check that the wifi compat HAL layer is available:
    wifi_compat_check_availability().

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 5d8b15b..1906221 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,13 @@
6+android-headers (23-0ubuntu5) UNRELEASED; urgency=medium
7+
8+ * Bump debhelper from old 9 to 10.
9+ * Use versioned copyright format URI.
10+ * Change priority extra to priority optional.
11+ * Don't specify --with=quilt, since package uses '3.0 (quilt)' source
12+ format.
13+
14+ -- Jelmer Vernooij <jelmer@debian.org> Sat, 19 Jan 2019 02:50:18 +0000
15+
16 android-headers (23-0ubuntu4) yakkety; urgency=medium
17
18 [ You-Sheng Yang ]
19diff --git a/debian/compat b/debian/compat
20index ec63514..f599e28 100644
21--- a/debian/compat
22+++ b/debian/compat
23@@ -1 +1 @@
24-9
25+10
26diff --git a/debian/control b/debian/control
27index aaca249..e5722cb 100644
28--- a/debian/control
29+++ b/debian/control
30@@ -1,8 +1,8 @@
31 Source: android-headers
32-Priority: extra
33+Priority: optional
34 Section: libdevel
35 Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
36-Build-Depends: debhelper (>= 9), quilt
37+Build-Depends: debhelper (>= 10~), quilt
38 Standards-Version: 3.9.6
39 Vcs-Git: https://git.launchpad.net/android-headers
40 Vcs-Browser: https://git.launchpad.net/android-headers
41diff --git a/debian/copyright b/debian/copyright
42index b19af0d..5eafb78 100644
43--- a/debian/copyright
44+++ b/debian/copyright
45@@ -1,4 +1,4 @@
46-Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
47+Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
48 Upstream-Name: android-headers
49 Source: https://android.googlesource.com/
50
51diff --git a/debian/rules b/debian/rules
52index 1e4efc0..657234c 100755
53--- a/debian/rules
54+++ b/debian/rules
55@@ -4,4 +4,4 @@
56 #export DH_VERBOSE=1
57
58 %:
59- dh $@ --with quilt
60+ dh $@

Subscribers

People subscribed via source and target branches