Merge lp:~jelmer/tribunal/no-print into lp:tribunal

Proposed by Jelmer Vernooij
Status: Merged
Approved by: Martin Pool
Approved revision: 166
Merged at revision: 174
Proposed branch: lp:~jelmer/tribunal/no-print
Merge into: lp:tribunal
Diff against target: 39 lines (+2/-6)
1 file modified
tribunal/inputdriver.py (+2/-6)
To merge this branch: bzr merge lp:~jelmer/tribunal/no-print
Reviewer Review Type Date Requested Status
Martin Pool Approve
Review via email: mp+51233@code.launchpad.net

Description of the change

This removes printing of all data that's read to stdout. This is a bit verbose, and slows the start up down when run from a terminal.

To post a comment you must log in.
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

ping?

Revision history for this message
Martin Pool (mbp) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tribunal/inputdriver.py'
2--- tribunal/inputdriver.py 2010-08-17 04:14:21 +0000
3+++ tribunal/inputdriver.py 2011-02-24 23:56:56 +0000
4@@ -85,9 +85,6 @@
5 break
6 else:
7 raise
8- if False:
9- print 'read %r, %r' % (source, condition)
10- print ' got %r' % line
11 if not line:
12 self._shutdown()
13 sys.stderr.write('done\n')
14@@ -99,7 +96,7 @@
15 def on_hangup(self, source, condition):
16 self._shutdown()
17 return False
18-
19+
20 def _remove_listeners(self):
21 for source_id in (self._hup_source_id, self._read_source_id):
22 if source_id is not None:
23@@ -116,7 +113,7 @@
24 StringIO, so we should be able to access it all with no physical IO, but
25 it may take some time to parse it.
26 """
27-
28+
29 def set_paused(self, paused):
30 pass # not supported; everything is read immediately
31
32@@ -127,7 +124,6 @@
33 while True:
34 # TODO: let the gtk loop run a bit
35 line = self.stream.readline()
36- print 'read %r' % line
37 if not line:
38 self._shutdown()
39 break

Subscribers

People subscribed via source and target branches

to all changes: