Merge lp:~jelmer/tribunal/icon into lp:tribunal

Proposed by Jelmer Vernooij
Status: Merged
Approved by: Martin Pool
Approved revision: 169
Merged at revision: 170
Proposed branch: lp:~jelmer/tribunal/icon
Merge into: lp:tribunal
Diff against target: 34 lines (+3/-3)
2 files modified
setup.py (+2/-2)
tribunal-subunit.desktop (+1/-1)
To merge this branch: bzr merge lp:~jelmer/tribunal/icon
Reviewer Review Type Date Requested Status
Martin Pool Approve
The Tribunal code Pending
Review via email: mp+42285@code.launchpad.net

Commit message

Install application icon using tribunal-gavel.

Description of the change

This makes us use xdg-icon-resource to install the application icon; this makes it possible to e.g. install in the users home directory.

To post a comment you must log in.
Revision history for this message
Martin Pool (mbp) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'setup.py'
--- setup.py 2010-09-26 21:38:52 +0000
+++ setup.py 2010-11-30 18:41:52 +0000
@@ -12,7 +12,8 @@
12 subprocess.check_call(['xdg-mime', 'install', 'tribunal-subunit.xml'])12 subprocess.check_call(['xdg-mime', 'install', 'tribunal-subunit.xml'])
13 subprocess.check_call(['xdg-desktop-menu', 'install',13 subprocess.check_call(['xdg-desktop-menu', 'install',
14 'tribunal-subunit.desktop'])14 'tribunal-subunit.desktop'])
1515 subprocess.check_call(['xdg-icon-resource', 'install', '--size', '64',
16 'tribunal/gavel_64x64.png', 'tribunal-gavel'])
1617
1718
18setup(name='tribunal',19setup(name='tribunal',
@@ -26,7 +27,6 @@
26 ['gavel_64x64.png', 'ui.glade']},27 ['gavel_64x64.png', 'ui.glade']},
27 data_files=[28 data_files=[
28 ('share/application-registry', ['tribunal.applications']),29 ('share/application-registry', ['tribunal.applications']),
29 ('share/pixmaps', ['tribunal/gavel_64x64.png']),
30 ],30 ],
31 scripts=['tribunal-subunit'],31 scripts=['tribunal-subunit'],
32 classifiers=[32 classifiers=[
3333
=== modified file 'tribunal-subunit.desktop'
--- tribunal-subunit.desktop 2010-09-26 21:26:20 +0000
+++ tribunal-subunit.desktop 2010-11-30 18:41:52 +0000
@@ -1,7 +1,7 @@
1[Desktop Entry]1[Desktop Entry]
2Name=Tribunal2Name=Tribunal
3Comment=View Subunit File3Comment=View Subunit File
4Icon=gavel_64x644Icon=tribunal-gavel
5Exec=tribunal-subunit %f5Exec=tribunal-subunit %f
6Terminal=false6Terminal=false
7Type=Application7Type=Application

Subscribers

People subscribed via source and target branches

to all changes: