Code review comment for lp:~jelmer/pygpgme/bug452194

Revision history for this message
James Henstridge (jamesh) wrote :

Looks pretty good. A few questions:

1. The documentation (http://www.gnupg.org/documentation/manuals/gpgme/Library-Version-Check.html) says this method can fail and return NULL. Please add a check for that.

2. Could you change the variable to lower case?

review: Needs Fixing

« Back to merge proposal