loggerhead

Merge lp:~jelmer/loggerhead/is-alive into lp:loggerhead

  1. is-alive
  2. Merge into trunk-rich
Proposed by Jelmer Vernooij
Status: Merged
Merged at revision: 520
Proposed branch: lp:~jelmer/loggerhead/is-alive
Merge into: lp:loggerhead
Diff against target: 12 lines (+1/-1)
1 file modified
loggerhead/load_test.py (+1/-1)
To merge this branch: bzr merge lp:~jelmer/loggerhead/is-alive
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+394502@code.launchpad.net

Commit message

Avoid Thread.isAlive, removed in newer versions of Python.

Description of the change

Avoid Thread.isAlive, removed in newer versions of Python.

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) :
review: Approve
Revision history for this message
Otto Co-Pilot (otto-copilot) wrote :

A commit message must be set
https://jenkins.ols.canonical.com/online-services/job/loggerhead/3/

Revision history for this message
Otto Co-Pilot (otto-copilot) wrote :

There was nothing to merge
https://jenkins.ols.canonical.com/online-services/job/loggerhead/4/

Revision history for this message
Colin Watson (cjwatson) wrote :

This was effectively merged via https://code.launchpad.net/~jelmer/loggerhead/drop-python3/+merge/411875.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'loggerhead/load_test.py'
2--- loggerhead/load_test.py 2020-07-08 17:14:19 +0000
3+++ loggerhead/load_test.py 2021-11-15 16:18:16 +0000
4@@ -211,7 +211,7 @@
5 # And join the controlling thread
6 for i in range(10):
7 t.join(self.blocking_timeout / 10.0)
8- if not t.isAlive():
9+ if not t.is_alive():
10 break
11
12 def _full_url(self, relpath):

Subscribers

People subscribed via source and target branches