Merge ~jelmer/launchpadlib:extra-keyring into launchpadlib:main

[Jelmer Vernooij]

Make keyring an extra

The keyring support in launchpadlib is already optional - the code is written such that it can function fine without keyring. However, in setup.py there is a hard dependency on keyring, which pulls in both keyring and its many dependencies (including e.g. dbus).

This moves keyring to an extra, which does mean that anybody that needs the keyring support will need to explicitly specify it. It would be nice if there was a way to add a no-keyring extra, but that's unfortunately not how pip works :-(

[Colin Watson (cjwatson)]

review: Approve

[Colin Watson (cjwatson)]

I think this is probably OK. I bumped the minor version to 1.11.0 to account for this.

[Jürgen Gmach (jugmac00)]

For my understanding...
Colin, as you are also the maintainer of the deb for launchpadlib.. what does this change mean for packaging the deb? Will keyring then also be an optional dependency?

[Colin Watson (cjwatson)]

Jelmer already made such a change in https://salsa.debian.org/python-team/packages/python-launchpadlib/-/commit/842dd5191ca3ef1acb800579b7a02cda6cbeeb31 (note that the commit message says Suggests when it should have said Recommends, but those are different "strengths" of optional dependency).

diff --git a/setup.py b/setup.py
index 002e766..58e1e84 100755
--- a/setup.py
+++ b/setup.py
@@ -44,7 +44,6 @@ def generate(*docname_or_string):
 install_requires = [
     "httplib2",
     'importlib-metadata; python_version < "3.8"',
-    "keyring",
     "lazr.restfulclient>=0.14.2",
     "lazr.uri",
     "six",
@@ -90,6 +89,7 @@ setup(
         "Programming Language :: Python :: 3.11",
     ],
     extras_require={
+        "keyring": ["keyring"],
         "docs": ["Sphinx"],
         # Dependencies useful when testing other packages with launchpadlib.
         "testing": [