Merge lp:~jelmer/launchpad/later-upload-move into lp:launchpad
Proposed by
Jelmer Vernooij
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Jelmer Vernooij | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 11991 | ||||
Proposed branch: | lp:~jelmer/launchpad/later-upload-move | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
34 lines (+3/-3) 2 files modified
lib/lp/archiveuploader/tests/test_uploadprocessor.py (+1/-1) lib/lp/archiveuploader/uploadprocessor.py (+2/-2) |
||||
To merge this branch: | bzr merge lp:~jelmer/launchpad/later-upload-move | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Julian Edwards (community) | Needs Information | ||
Jelmer Vernooij (community) | Approve | ||
Review via email: mp+41749@code.launchpad.net |
Commit message
[r=jelmer]
Description of the change
We've had two bugs with builds that failed to upload. They would be moved out of the queue but before their build status was updated (to FULLYBUILT or FAILEDTOUPLOAD).
This changes the move to be right after the database commit. This means the window for inconsistency is very small.
To post a comment you must log in.
(I had a pre-implementation discussion about this with Julian, but he hasn't done an actual code review).