Merge lp:~jelmer/launchpad/621778-parse-homepage-field into lp:launchpad/db-devel
Proposed by
Jelmer Vernooij
Status: | Merged |
---|---|
Approved by: | Jelmer Vernooij |
Approved revision: | no longer in the source branch. |
Merged at revision: | 9738 |
Proposed branch: | lp:~jelmer/launchpad/621778-parse-homepage-field |
Merge into: | lp:launchpad/db-devel |
Prerequisite: | lp:~jelmer/launchpad/621778-homepage-field |
Diff against target: |
296 lines (+52/-26) 6 files modified
lib/lp/archiveuploader/dscfile.py (+2/-0) lib/lp/archiveuploader/nascentuploadfile.py (+14/-14) lib/lp/archiveuploader/tests/test_nascentuploadfile.py (+29/-7) lib/lp/registry/browser/product.py (+3/-1) lib/lp/registry/stories/product/xx-product-add.txt (+2/-2) lib/lp/soyuz/tests/test_publishing.py (+2/-2) |
To merge this branch: | bzr merge lp:~jelmer/launchpad/621778-parse-homepage-field |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jeroen T. Vermeulen (community) | code | Approve | |
Review via email: mp+33334@code.launchpad.net |
Commit message
Parse Homepage field and store it in SourcePackageRe
Description of the change
This adds support for parsing the Homepage field from SourcePackageRe
To post a comment you must log in.
Looks good. Just two notes:
In line 49 of the diff: don't bother documenting tests as "Test that…" That's obvious from them being test methods. Just takes up space.
In line 94 of the diff: badly formatted line break. Try putting both arguments to the assertEqual together on the line after the invocation.
Please mention the "make lint" output in your merge proposals so that your reviewer doesn't need to worry about whether they have to play human linter. If there's too much pre-existing lint, well, throw in some drive-by cleanups!