Merge lp:~jelmer/launchpad/621778-homepage-field into lp:launchpad/db-devel
Proposed by
Jelmer Vernooij
Status: | Merged |
---|---|
Approved by: | Jelmer Vernooij |
Approved revision: | no longer in the source branch. |
Merged at revision: | 9719 |
Proposed branch: | lp:~jelmer/launchpad/621778-homepage-field |
Merge into: | lp:launchpad/db-devel |
Diff against target: |
269 lines (+80/-10) 13 files modified
database/schema/comments.sql (+2/-0) database/schema/patch-2208-05-0.sql (+11/-0) lib/lp/registry/interfaces/distroseries.py (+4/-1) lib/lp/registry/model/distroseries.py (+3/-2) lib/lp/soyuz/interfaces/binarypackagebuild.py (+1/-1) lib/lp/soyuz/interfaces/binarypackagerelease.py (+7/-0) lib/lp/soyuz/interfaces/sourcepackagerelease.py (+8/-0) lib/lp/soyuz/model/binarypackagebuild.py (+2/-2) lib/lp/soyuz/model/binarypackagerelease.py (+1/-0) lib/lp/soyuz/model/sourcepackagerelease.py (+1/-0) lib/lp/soyuz/tests/test_binarypackagerelease.py (+16/-0) lib/lp/soyuz/tests/test_sourcepackagerelease.py (+16/-0) lib/lp/testing/factory.py (+8/-4) |
To merge this branch: | bzr merge lp:~jelmer/launchpad/621778-homepage-field |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tim Penhey (community) | Approve | ||
Steve Kowalik (community) | code* | Approve | |
Stuart Bishop (community) | db | Approve | |
Robert Collins (community) | db | Approve | |
Review via email: mp+33331@code.launchpad.net |
Commit message
Add SourcePackageRe
Description of the change
This adds a "Homepage" field to SourcePackageRe
This field was added to the Debian policy a fairly recently, see http://
I'm adding this field so that it can be used as the default value for the upstream homepage URL when creating an upstream project from an Ubuntu source package.
See: https:/
To post a comment you must log in.
If you're adding in python support for this, I think a couple of tests would be sensible: e.g. that you want it nullable.
DB side looks fine.