Merge lp:~jelmer/launchpad/600153-qafix into lp:launchpad
Proposed by
Jelmer Vernooij
Status: | Merged |
---|---|
Approved by: | Brad Crittenden |
Approved revision: | no longer in the source branch. |
Merged at revision: | 11239 |
Proposed branch: | lp:~jelmer/launchpad/600153-qafix |
Merge into: | lp:launchpad |
Diff against target: |
54 lines (+5/-8) 2 files modified
lib/lp/soyuz/model/archive.py (+3/-4) lib/lp/soyuz/model/publishing.py (+2/-4) |
To merge this branch: | bzr merge lp:~jelmer/launchpad/600153-qafix |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Approve | |
Launchpad code reviewers from Canonical | code | Pending | |
Review via email: mp+30790@code.launchpad.net |
Description of the change
This fixes the qa-badness of bug 600153. process-upload was manually looking at ArchiveArch to determine what restricted architectures the archive could build on rather than checking Archive.
To post a comment you must log in.
Hi Jelmer,
Please sort your import items alphabetically.
Based on the QA report this change looks good (though I can't claim deep enough knowledge to know for sure).
You didn't add or modify any tests for this change. Is this fix not testable? Would an appropriate test on the original branch have avoided the second round?