Launchpad itself

Code review comment for lp:~jelmer/launchpad/506256-remove-popen

  1. 506256-remove-popen
  2. Merge into devel
Revision history for this message
Julian Edwards (julian-edwards) wrote :

My two pence, as I mentioned on Mumble:

 1. Please change the added __getitem__ to a getByID() method. We're deprecating __getitem__
 2. Typo in the new enum (s/process/processed/)

Otherwise, ROCK!

review: Approve

« Back to merge proposal