Code review comment for lp:~jelmer/bzr/urllib-verifies-ssl-certs

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

> Added what's new text is great, and the new logic for printing helpful
> messages seems good. Some of these messages could probably do with gettext()
> added, but that can wait for another branch when the rest of the module can be
> looked over too.
> - if cert_reqs == "none":
> + if cert_reqs == ssl.CERT_NONE:
> Seen in the interdiff for the last change, was this broken before, and did a
> test fail because of it?
Yeah, it was indeed broken - and I hadn't noticed since we don't have a test for it. There is an open bug about doing more testing with SSL certificates.

« Back to merge proposal