Code review comment for lp:~jelmer/bzr/urllib-verifies-ssl-certs

Revision history for this message
Martin Packman (gz) wrote :

I think there's general agreement this is great, and with the reqirement of Python 2.6 something that's now acheivable and should probably get into the next bzr release.

It absolutely needs some kind of automated testing though, and likely an option for disabling checks, I've used `curl -k` and `wget --no-check-certificate` enough to know I'd be annoyed if that option wasn't there.

review: Needs Fixing

« Back to merge proposal