[needsinfo] It seems merge_to changes caused problems in the past
(see bzrlib.tags._merge_tags_if_possible), what's your feeling on
changing the signature again and the possible fallouts ? (loom ?)
Or did I misread the diff and merge_to didn't return anything
before ? Or does it matter nevertheless ?
[needsfixing] There is a lot of duplication between
PullResult.report() and BranchPushResult.report()
But one is using to_file_write.write() and the other
trace.note(). This doesn't feel right, shouldn't they both
provide the same feedback to the user ?
[needsinfo] It seems merge_to changes caused problems in the past tags._merge_ tags_if_ possible) , what's your feeling on
(see bzrlib.
changing the signature again and the possible fallouts ? (loom ?)
Or did I misread the diff and merge_to didn't return anything
before ? Or does it matter nevertheless ?
[needsfixing] There is a lot of duplication between t.report( )
PullResult.report() and BranchPushResul
But one is using to_file_ write.write( ) and the other
trace.note(). This doesn't feel right, shouldn't they both
provide the same feedback to the user ?
[PEP8 nit] tag_conflicts = self.source. tags.merge_ to( to_master)
75 + result.tag_updates, result.
76 + self.target.tags, overwrite, ignore_master=not merge_tags_
lines too long.
[2.4-worthy] Shouldn't that be backported for the benefit of the
package importer ?