Merge lp:~jelmer/bzr/reproducible-builds-1 into lp:bzr

Proposed by Jelmer Vernooij on 2015-04-18
Status: Merged
Approved by: Richard Wilbur on 2015-04-20
Approved revision: 6603
Merged at revision: 6603
Proposed branch: lp:~jelmer/bzr/reproducible-builds-1
Merge into: lp:bzr
Diff against target: 23 lines (+0/-3)
2 files modified
bzrlib/doc_generate/autodoc_man.py (+0/-2)
bzrlib/doc_generate/autodoc_rstx.py (+0/-1)
To merge this branch: bzr merge lp:~jelmer/bzr/reproducible-builds-1
Reviewer Review Type Date Requested Status
Richard Wilbur 2015-04-18 Approve on 2015-04-20
Review via email: mp+256747@code.launchpad.net

Commit message

(jelmer)Make bzr build reproducible for Debian.

Description of the change

Remove the generation timestamp from two doc files.

This makes the bzr build reproducible (multiple runs in the same environment produce the same files).

Debian is trying to make all package reproducible. For reasoning, see https://wiki.debian.org/ReproducibleBuilds/About

To post a comment you must log in.
Richard Wilbur (richard-wilbur) wrote :

Thanks for the changes and the link. I applaud the Debian project and their goals of reproducible builds and am happy to support these change.

+1

review: Approve
Richard Wilbur (richard-wilbur) wrote :

sent to pqm by email

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bzrlib/doc_generate/autodoc_man.py'
2--- bzrlib/doc_generate/autodoc_man.py 2012-03-16 13:46:56 +0000
3+++ bzrlib/doc_generate/autodoc_man.py 2015-04-18 22:05:19 +0000
4@@ -189,8 +189,6 @@
5 .\\\" \"%(bzrcmd)s help commands\"
6 .\\\" \"%(bzrcmd)s help <cmd>\"
7 .\\\"
8-.\\\" Generation time: %(timestamp)s
9-.\\\"
10
11 .ie \\n(.g .ds Aq \\(aq
12 .el .ds Aq '
13
14=== modified file 'bzrlib/doc_generate/autodoc_rstx.py'
15--- bzrlib/doc_generate/autodoc_rstx.py 2014-05-08 01:28:12 +0000
16+++ bzrlib/doc_generate/autodoc_rstx.py 2015-04-18 22:05:19 +0000
17@@ -144,7 +144,6 @@
18 .. %(bzrcmd)s help commands
19 .. %(bzrcmd)s help <cmd>
20 ..
21-.. Generation time: %(timestamp)s
22
23 """
24