Merge lp:~jelmer/bzr/remote-addinvdelta into lp:bzr

Proposed by Jelmer Vernooij
Status: Merged
Approved by: Jelmer Vernooij
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp:~jelmer/bzr/remote-addinvdelta
Merge into: lp:bzr
Diff against target: 31 lines (+6/-2)
2 files modified
NEWS (+3/-0)
bzrlib/remote.py (+3/-2)
To merge this branch: bzr merge lp:~jelmer/bzr/remote-addinvdelta
Reviewer Review Type Date Requested Status
Robert Collins (community) Needs Fixing
Patrick Noffke (community) code Approve
Review via email: mp+20846@code.launchpad.net

Commit message

(Jelmer) Handle new parameters in RemoteRepository.add_inventory_by_delta().

Description of the change

This makes RemoteRepository.add_inventory_by_delta() support the extra arguments that Repository.add_inventory_by_delta() also supports.

To post a comment you must log in.
Revision history for this message
Patrick Noffke (patrick-noffke) wrote :
review: Approve (code)
Revision history for this message
Robert Collins (lifeless) wrote :

please pass the keyword args as keyword args.
bb:tweak.

review: Needs Fixing
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'NEWS'
2--- NEWS 2010-03-05 08:55:12 +0000
3+++ NEWS 2010-03-09 23:50:44 +0000
4@@ -107,6 +107,9 @@
5 the debugger won't kill the session.
6 (Martin <gzlist@googlemail.com>, #162502)
7
8+* Allow additional arguments to
9+ ``RemoteRepository.add_inventory_by_delta()``. (Jelmer Vernooij, #532631)
10+
11 * Tolerate patches with leading noise in ``bzr-handle-patch``.
12 (Toshio Kuratomi, Martin Pool, #502076)
13
14
15=== modified file 'bzrlib/remote.py'
16--- bzrlib/remote.py 2010-03-02 19:50:18 +0000
17+++ bzrlib/remote.py 2010-03-09 23:50:44 +0000
18@@ -1234,10 +1234,11 @@
19 return self._real_repository.add_inventory(revid, inv, parents)
20
21 def add_inventory_by_delta(self, basis_revision_id, delta, new_revision_id,
22- parents):
23+ parents, basis_inv=None, propagate_caches=False):
24 self._ensure_real()
25 return self._real_repository.add_inventory_by_delta(basis_revision_id,
26- delta, new_revision_id, parents)
27+ delta, new_revision_id, parents, basis_inv=basis_inv,
28+ propagate_caches=propagate_caches)
29
30 def add_revision(self, rev_id, rev, inv=None, config=None):
31 self._ensure_real()