Merge lp:~jelmer/bzr/info-lock-without-repo into lp:bzr/2.5

[Jelmer Vernooij]

Fix 'bzr info -v' for a control directory without a repository.

Fix "bzr info -v" when run on an empty control directory without a repository, branch or working tree.

[Vincent Ladeuil (vila)]

review: Approve

[Martin Pool (mbp)]

great, thankyou!

  vote approve

review: Approve

[Jelmer Vernooij (jelmer)]

sent to pqm by email

=== modified file 'bzrlib/info.py'
--- bzrlib/info.py	2012-01-18 20:47:13 +0000
+++ bzrlib/info.py	2012-02-20 13:48:17 +0000
@@ -200,9 +200,10 @@
             repository._format.get_format_description())
 
 
-def _show_locking_info(repository, branch=None, working=None, outfile=None):
+def _show_locking_info(repository=None, branch=None, working=None,
+        outfile=None):
     """Show locking status of working, branch and repository."""
-    if (repository.get_physical_lock_status() or
+    if (repository and repository.get_physical_lock_status() or
         (branch and branch.get_physical_lock_status()) or
         (working and working.get_physical_lock_status())):
         outfile.write('\n')
@@ -413,11 +414,12 @@
     if branch is not None:
         show_committers = verbose >= 2
         stats = _show_branch_stats(branch, show_committers, outfile)
-    else:
+    elif repository is not None:
         stats = repository.gather_stats()
-    if branch is None and working is None:
+    if branch is None and working is None and repository is not None:
         _show_repository_info(repository, outfile)
-    _show_repository_stats(repository, stats, outfile)
+    if repository is not None:
+        _show_repository_stats(repository, stats, outfile)
 
 
 def describe_layout(repository=None, branch=None, tree=None, control=None):

=== modified file 'bzrlib/tests/blackbox/test_info.py'
--- bzrlib/tests/blackbox/test_info.py	2012-01-26 15:36:39 +0000
+++ bzrlib/tests/blackbox/test_info.py	2012-02-20 13:48:17 +0000
@@ -57,6 +57,19 @@
             '  control directory: ctrl\n')
         self.assertEquals(err, '')
 
+    def test_info_empty_controldir_verbose(self):
+        self.make_bzrdir('ctrl')
+        out, err = self.run_bzr('info -v ctrl')
+        self.assertEqualDiff(out,
+            'Empty control directory (format: 2a or pack-0.92)\n'
+            'Location:\n'
+            '  control directory: ctrl\n\n'
+            'Format:\n'
+            '       control: Meta directory format 1\n\n'
+            'Control directory:\n'
+            '         0 branches\n')
+        self.assertEquals(err, '')
+
     def test_info_dangling_branch_reference(self):
         br = self.make_branch('target')
         br.create_checkout('from', lightweight=True)

=== modified file 'doc/en/release-notes/bzr-2.5.txt'
--- doc/en/release-notes/bzr-2.5.txt	2012-02-16 18:01:57 +0000
+++ doc/en/release-notes/bzr-2.5.txt	2012-02-20 13:48:17 +0000
@@ -36,6 +36,9 @@
 .. Fixes for situations where bzr would previously crash or give incorrect
    or undesirable results.
 
+* Show locks in ``bzr info`` on control directories without a
+  repository. (Jelmer Vernooij, #936767)
+
 * Disable ssl certificate verification on osx and windows until a native
   access to the the root certificates is provided there.
   (Vincent Ladeuil, #929179)