Merge lp:~jelmer/bzr-fastimport/import-helpers into lp:bzr-fastimport

[Jelmer Vernooij]

Add the bzr-specific helpers that were removed from python-fastimport.

This fixes bzr-fastimport when used with newer versions of python-fastimport (>= 0.9.3).

[Zygmunt Krynicki (zyga)]

Looks good to me

[Richard Wilbur (richard-wilbur)]

Thanks, Jelmer, for putting the pieces back together.
+1

review: Approve

=== modified file 'branch_updater.py'
--- branch_updater.py	2012-12-03 11:01:51 +0000
+++ branch_updater.py	2014-05-15 09:40:01 +0000
@@ -22,6 +22,7 @@
 
 from bzrlib.plugins.fastimport.helpers import (
     best_format_for_objects_in_a_repository,
+    single_plural,
     )
 
 
@@ -149,7 +150,6 @@
 
         :return: whether the branch was changed or not
         """
-        from fastimport.helpers import single_plural
         last_rev_id = self.cache_mgr.lookup_committish(last_mark)
         self.repo.lock_read()
         try:

=== modified file 'cache_manager.py'
--- cache_manager.py	2012-02-28 14:00:56 +0000
+++ cache_manager.py	2014-05-15 09:40:01 +0000
@@ -28,7 +28,7 @@
 from bzrlib.plugins.fastimport.reftracker import (
     RefTracker,
     )
-from fastimport.helpers import (
+from bzrlib.plugins.fastimport.helpers import (
     single_plural,
     )
 
@@ -275,3 +275,14 @@
         return content
 
 
+def invert_dictset(d):
+    """Invert a dictionary with keys matching a set of values, turned into lists."""
+    # Based on recipe from ASPN
+    result = {}
+    for k, c in d.iteritems():
+        for v in c:
+            keys = result.setdefault(v, [])
+            keys.append(k)
+    return result
+
+

=== modified file 'cmds.py'
--- cmds.py	2014-04-16 05:59:09 +0000
+++ cmds.py	2014-05-15 09:40:01 +0000
@@ -19,7 +19,10 @@
 from bzrlib.commands import Command
 from bzrlib.option import Option, ListOption, RegistryOption
 
-from bzrlib.plugins.fastimport import load_fastimport
+from bzrlib.plugins.fastimport import (
+    helpers,
+    load_fastimport,
+    )
 
 
 def _run(source, processor_factory, verbose=False, user_map=None, **kwargs):
@@ -47,7 +50,6 @@
 def _get_source_stream(source):
     if source == '-' or source is None:
         import sys
-        from fastimport import helpers
         stream = helpers.binary_stream(sys.stdin)
     elif source.endswith('.gz'):
         import gzip

=== modified file 'exporter.py'
--- exporter.py	2012-08-21 10:08:53 +0000
+++ exporter.py	2014-05-15 09:40:01 +0000
@@ -64,7 +64,7 @@
     )
 
 from fastimport import commands
-from fastimport.helpers import (
+from bzrlib.plugins.fastimport.helpers import (
     binary_stream,
     single_plural,
     )

=== modified file 'helpers.py'
--- helpers.py	2011-10-06 00:11:52 +0000
+++ helpers.py	2014-05-15 09:40:01 +0000
@@ -146,3 +146,53 @@
         return 'tree-reference', False
     else:
         raise AssertionError("invalid mode %o" % mode)
+
+
+def binary_stream(stream):
+    """Ensure a stream is binary on Windows.
+
+    :return: the stream
+    """
+    try:
+        import os
+        if os.name == 'nt':
+            fileno = getattr(stream, 'fileno', None)
+            if fileno:
+                no = fileno()
+                if no >= 0:     # -1 means we're working as subprocess
+                    import msvcrt
+                    msvcrt.setmode(no, os.O_BINARY)
+    except ImportError:
+        pass
+    return stream
+
+
+def single_plural(n, single, plural):
+    """Return a single or plural form of a noun based on number."""
+    if n == 1:
+        return single
+    else:
+        return plural
+
+
+def invert_dictset(d):
+    """Invert a dictionary with keys matching a set of values, turned into lists."""
+    # Based on recipe from ASPN
+    result = {}
+    for k, c in d.iteritems():
+        for v in c:
+            keys = result.setdefault(v, [])
+            keys.append(k)
+    return result
+
+
+def invert_dict(d):
+    """Invert a dictionary with keys matching each value turned into a list."""
+    # Based on recipe from ASPN
+    result = {}
+    for k, v in d.iteritems():
+        keys = result.setdefault(v, [])
+        keys.append(k)
+    return result
+
+

=== modified file 'processors/generic_processor.py'
--- processors/generic_processor.py	2012-02-28 14:00:56 +0000
+++ processors/generic_processor.py	2014-05-15 09:40:01 +0000
@@ -40,6 +40,7 @@
 from bzrlib.plugins.fastimport import (
     branch_updater,
     cache_manager,
+    helpers,
     idmapfile,
     marks_file,
     revision_store,
@@ -47,7 +48,6 @@
 from fastimport import (
     commands,
     errors as plugin_errors,
-    helpers,
     processor,
     )
 

=== modified file 'processors/info_processor.py'
--- processors/info_processor.py	2012-02-28 14:00:56 +0000
+++ processors/info_processor.py	2014-05-15 09:40:01 +0000
@@ -18,14 +18,14 @@
 from bzrlib.plugins.fastimport import (
     reftracker,
     )
+from bzrlib.plugins.fastimport.helpers import (
+    invert_dict,
+    invert_dictset,
+    )
 from fastimport import (
     commands,
     processor,
     )
-from fastimport.helpers import (
-    invert_dict,
-    invert_dictset,
-    )
 import stat