Merge lp:~jelmer/bzr-builddeb/package-merge-first into lp:bzr-builddeb

Proposed by Jelmer Vernooij
Status: Merged
Approved by: James Westby
Approved revision: 593
Merged at revision: 590
Proposed branch: lp:~jelmer/bzr-builddeb/package-merge-first
Merge into: lp:bzr-builddeb
Prerequisite: lp:~jelmer/bzr-builddeb/import-dsc-incremental
Diff against target: 59 lines (+17/-7)
3 files modified
cmds.py (+10/-6)
debian/changelog (+2/-1)
tests/blackbox/test_builddeb.py (+5/-0)
To merge this branch: bzr merge lp:~jelmer/bzr-builddeb/package-merge-first
Reviewer Review Type Date Requested Status
James Westby Approve
Review via email: mp+68408@code.launchpad.net

Description of the change

Fix the use of "bzr builddeb --package-merge" if there are no previous uploads.

To post a comment you must log in.
593. By Jelmer Vernooij

use -v0 if there were no previous uploads.

Revision history for this message
James Westby (james-w) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cmds.py'
2--- cmds.py 2011-07-19 15:05:54 +0000
3+++ cmds.py 2011-07-19 16:04:35 +0000
4@@ -360,14 +360,18 @@
5
6 if package_merge:
7 try:
8- prev_version = find_previous_upload(tree, not contains_upstream_source)
9+ prev_version = find_previous_upload(tree,
10+ not contains_upstream_source)
11 except NoPreviousUpload:
12 prev_version = None
13- build_options.append("-v%s" % str(prev_version))
14- if (prev_version.upstream_version
15- != changelog.version.upstream_version
16- or prev_version.epoch != changelog.version.epoch):
17- build_options.append("-sa")
18+ if prev_version is None:
19+ build_options.extend(["-sa", "-v0"])
20+ else:
21+ build_options.append("-v%s" % str(prev_version))
22+ if (prev_version.upstream_version !=
23+ changelog.version.upstream_version or
24+ prev_version.epoch != changelog.version.epoch):
25+ build_options.append("-sa")
26 build_cmd = self._get_build_command(config, builder, quick,
27 build_options)
28 result_dir, build_dir, orig_dir = self._get_dirs(config,
29
30=== modified file 'debian/changelog'
31--- debian/changelog 2011-07-19 15:05:54 +0000
32+++ debian/changelog 2011-07-19 16:04:35 +0000
33@@ -3,8 +3,9 @@
34 * Bump standards version to 3.9.2 (no changes).
35 * Fix AttributeError in incremental imports using 'bzr import-dsc'.
36 LP: #812950
37+ * Support --package-merge for the first package version. LP: #812704
38
39- -- Jelmer Vernooij <jelmer@debian.org> Tue, 19 Jul 2011 17:05:38 +0200
40+ -- Jelmer Vernooij <jelmer@debian.org> Tue, 19 Jul 2011 17:35:39 +0200
41
42 bzr-builddeb (2.7.5) unstable; urgency=low
43
44
45=== modified file 'tests/blackbox/test_builddeb.py'
46--- tests/blackbox/test_builddeb.py 2011-06-13 23:01:14 +0000
47+++ tests/blackbox/test_builddeb.py 2011-07-19 16:04:35 +0000
48@@ -151,6 +151,11 @@
49 self.run_bzr('bd --dont-purge --native --builder "touch built"')
50 self.assertInBuildDir('built')
51
52+ def test_package_merge_first(self):
53+ tree = self.make_unpacked_source()
54+ self.make_upstream_tarball()
55+ self.run_bzr('bd --package-merge --builder true')
56+
57 def test_hooks(self):
58 tree = self.make_unpacked_source()
59 self.make_upstream_tarball()

Subscribers

People subscribed via source and target branches