Merge lp:~jelmer/bzr-builddeb/merge-2 into lp:~bzr-builddeb-hackers/bzr-builddeb/trunk-old
- merge-2
- Merge into trunk-old
Proposed by
Jelmer Vernooij
Status: | Merged |
---|---|
Merge reported by: | James Westby |
Merged at revision: | not available |
Proposed branch: | lp:~jelmer/bzr-builddeb/merge-2 |
Merge into: | lp:~bzr-builddeb-hackers/bzr-builddeb/trunk-old |
Diff against target: | None lines |
To merge this branch: | bzr merge lp:~jelmer/bzr-builddeb/merge-2 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
James Westby | Approve | ||
Review via email:
|
Commit message
Description of the change
To post a comment you must log in.
Revision history for this message
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Jelmer Vernooij (jelmer) wrote : | # |
Revision history for this message
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
James Westby (james-w) wrote : | # |
Merged, Thanks.
James
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1 | === modified file 'cmds.py' |
2 | --- cmds.py 2009-03-04 13:05:56 +0000 |
3 | +++ cmds.py 2009-04-15 15:08:32 +0000 |
4 | @@ -701,7 +701,7 @@ |
5 | try: |
6 | if last_version is not None: |
7 | if not db.has_upstream_version_in_packaging_branch( |
8 | - last_version): |
9 | + last_version.upstream_version): |
10 | raise BzrCommandError("Unable to find the tag for " |
11 | "the previous upstream version, %s, in the " |
12 | "branch: %s" % (last_version, |
13 | |
14 | === modified file 'import_dsc.py' |
15 | --- import_dsc.py 2009-03-11 07:23:20 +0000 |
16 | +++ import_dsc.py 2009-04-15 15:08:32 +0000 |
17 | @@ -497,7 +497,8 @@ |
18 | part of the version number from. |
19 | :return: a String with the name of the tag. |
20 | """ |
21 | - tag_name = self.tag_name(version.upstream_version) |
22 | + assert isinstance(version, str) |
23 | + tag_name = self.tag_name(version) |
24 | if distro is None: |
25 | return "upstream-" + tag_name |
26 | return "upstream-%s-%s" % (distro, tag_name) |
27 | @@ -556,8 +557,8 @@ |
28 | string passed must the the md5sum that is associated with the |
29 | revision pointed to by the tag. |
30 | |
31 | - :param version: a Version object from which to extract the upstream |
32 | - version number to look for in the upstream branch. |
33 | + :param version: a upstream version number to look for in the upstream |
34 | + branch. |
35 | :param md5: a string with the md5sum that if not None must be |
36 | associated with the revision. |
37 | :return: True if the upstream branch contains the specified upstream |
38 | @@ -575,6 +576,7 @@ |
39 | return False |
40 | |
41 | def has_upstream_version_in_packaging_branch(self, version, md5=None): |
42 | + assert isinstance(version, str) |
43 | tag_name = self.upstream_tag_name(version) |
44 | if self._has_version(self.branch, tag_name, md5=md5): |
45 | return True |
46 | @@ -714,9 +716,10 @@ |
47 | Sets a tag on the last revision of the upstream branch with a tag |
48 | that refers to the upstream part of the version provided. |
49 | |
50 | - :param version: the Version object from which to extract the upstream |
51 | - part of the version number to derive the tag name from. |
52 | + :param version: the upstream part of the version number to derive the |
53 | + tag name from. |
54 | """ |
55 | + assert isinstance(version, str) |
56 | tag_name = self.upstream_tag_name(version) |
57 | self.upstream_branch.tags.set_tag(tag_name, |
58 | self.upstream_branch.last_revision()) |
59 | @@ -819,13 +822,14 @@ |
60 | indicates that a pull should be done from that branch, rather |
61 | than importing the upstream as a new revision in this branch. |
62 | |
63 | - :param version: the Version object to use the upstream part |
64 | - of when searching in the lesser branches. |
65 | + :param version: the upstream version to use when searching in the |
66 | + lesser branches. |
67 | :param md5: a String containing the md5 associateed with the |
68 | upstream version. |
69 | :return: a DistributionBranch object to pull the upstream from |
70 | if that is what should be done, otherwise None. |
71 | """ |
72 | + assert isinstance(version, str) |
73 | assert md5 is not None, \ |
74 | ("It's not a good idea to use branch_to_pull_upstream_from with " |
75 | "md5 == None, as you may pull the wrong revision.") |
76 | @@ -927,11 +931,12 @@ |
77 | recognised as being part of this branch. |
78 | |
79 | :param pull_branch: the DistributionBranch to pull from. |
80 | - :param version: the Version to use the upstream part of. |
81 | + :param version: the upstream version string |
82 | """ |
83 | + assert isinstance(version, str) |
84 | pull_revision = pull_branch.revid_of_upstream_version(version) |
85 | mutter("Pulling upstream part of %s from revision %s" % \ |
86 | - (str(version), pull_revision)) |
87 | + (version, pull_revision)) |
88 | up_pull_branch = pull_branch.upstream_branch |
89 | assert self.upstream_tree is not None, \ |
90 | "Can't pull upstream with no tree" |
91 | @@ -967,9 +972,10 @@ |
92 | assert self.tree is not None, "Can't pull branch with no tree" |
93 | self.tree.pull(pull_branch.branch, stop_revision=pull_revision) |
94 | self.tag_version(version) |
95 | - if not native and not self.has_upstream_version(version): |
96 | - if pull_branch.has_upstream_version(version): |
97 | - self.pull_upstream_from_branch(pull_branch, version) |
98 | + if not native and not self.has_upstream_version(version.upstream_version): |
99 | + if pull_branch.has_upstream_version(version.upstream_version): |
100 | + self.pull_upstream_from_branch(pull_branch, |
101 | + version.upstream_version) |
102 | else: |
103 | assert False, "Can't find the needed upstream part" |
104 | if (native and self.upstream_branch.last_revision() == NULL_REVISION |
105 | @@ -1021,7 +1027,7 @@ |
106 | break |
107 | real_parents = [p[2] for p in parents] |
108 | if need_upstream_parent: |
109 | - parent_revid = self.revid_of_upstream_version(version) |
110 | + parent_revid = self.revid_of_upstream_version(version.upstream_version) |
111 | if len(parents) > 0: |
112 | real_parents.insert(1, parent_revid) |
113 | else: |
114 | @@ -1063,7 +1069,7 @@ |
115 | |
116 | :param upstream_part: the path of a directory containing the |
117 | unpacked upstream part of the source package. |
118 | - :param version: the Version of the package that is being imported. |
119 | + :param version: upstream version that is being imported |
120 | :param md5: the md5 of the upstream part. |
121 | :param upstream_parents: the parents to give the upstream revision |
122 | """ |
123 | @@ -1072,6 +1078,7 @@ |
124 | # from lesser branches first? For now we'll just dump it on. |
125 | # TODO: this method needs a lot of work for when we will make |
126 | # the branches writeable by others. |
127 | + assert isinstance(version, str) |
128 | mutter("Importing upstream version %s from %s with parents %s" \ |
129 | % (version, upstream_part, str(upstream_parents))) |
130 | assert self.upstream_tree is not None, \ |
131 | @@ -1104,7 +1111,7 @@ |
132 | uuencoded = standard_b64encode(delta) |
133 | revprops["deb-pristine-delta"] = uuencoded |
134 | revid = self.upstream_tree.commit("Import upstream version %s" \ |
135 | - % (str(version.upstream_version),), |
136 | + % (version,), |
137 | revprops=revprops) |
138 | self.tag_upstream_version(version) |
139 | return revid |
140 | @@ -1295,7 +1302,7 @@ |
141 | # upstream as a non-native version (i.e. it wasn't a mistaken |
142 | # native -2 version), then we want to add an extra parent. |
143 | if (self.is_version_native(last_contained_version) |
144 | - and not self.has_upstream_version(last_contained_version)): |
145 | + and not self.has_upstream_version(last_contained_version.upstream_version)): |
146 | revid = self.revid_of_version(last_contained_version) |
147 | parents.append(revid) |
148 | self.upstream_branch.fetch(self.branch, |
149 | @@ -1307,7 +1314,7 @@ |
150 | pull_version = pull_parents[0][1] |
151 | if not pull_branch.is_version_native(pull_version): |
152 | pull_revid = \ |
153 | - pull_branch.revid_of_upstream_version(pull_version) |
154 | + pull_branch.revid_of_upstream_version(pull_version.upstream_version) |
155 | mutter("Initialising upstream from %s, version %s" \ |
156 | % (str(pull_branch), str(pull_version))) |
157 | parents.append(pull_revid) |
158 | @@ -1344,17 +1351,20 @@ |
159 | # We need to import at least the diff, possibly upstream. |
160 | # Work out if we need the upstream part first. |
161 | imported_upstream = False |
162 | - if not self.has_upstream_version(version): |
163 | + if not self.has_upstream_version(version.upstream_version): |
164 | up_pull_branch = \ |
165 | - self.branch_to_pull_upstream_from(version, upstream_md5) |
166 | + self.branch_to_pull_upstream_from(version.upstream_version, |
167 | + upstream_md5) |
168 | if up_pull_branch is not None: |
169 | - self.pull_upstream_from_branch(up_pull_branch, version) |
170 | + self.pull_upstream_from_branch(up_pull_branch, |
171 | + version.upstream_version) |
172 | else: |
173 | imported_upstream = True |
174 | # Check whether we should pull first if this initialises |
175 | # from another branch: |
176 | upstream_parents = self.upstream_parents(versions) |
177 | - new_revid = self.import_upstream(upstream_part, version, |
178 | + new_revid = self.import_upstream(upstream_part, |
179 | + version.upstream_version, |
180 | upstream_md5, upstream_parents, |
181 | upstream_tarball=upstream_tarball) |
182 | self._fetch_upstream_to_branch(new_revid) |
183 | @@ -1536,7 +1546,7 @@ |
184 | try: |
185 | if previous_version is not None: |
186 | if not self.has_upstream_version_in_packaging_branch( |
187 | - previous_version): |
188 | + previous_version.upstream_version): |
189 | raise BzrCommandError("Unable to find the tag for the " |
190 | "previous upstream version, %s, in the branch: " |
191 | "%s" % (previous_version, |
192 | @@ -1546,7 +1556,7 @@ |
193 | self._extract_upstream_tree(upstream_tip, tempdir) |
194 | else: |
195 | self._create_empty_upstream_tree(tempdir) |
196 | - if self.has_upstream_version_in_packaging_branch(version): |
197 | + if self.has_upstream_version_in_packaging_branch(version.upstream_version): |
198 | raise UpstreamAlreadyImported(version) |
199 | try: |
200 | if upstream_branch is not None: |
201 | @@ -1603,6 +1613,7 @@ |
202 | |
203 | def reconstruct_pristine_tar(self, revid, package, version, |
204 | dest_filename): |
205 | + """Reconstruct a pristine-tar tarball from a bzr revision.""" |
206 | if not os.path.exists("/usr/bin/pristine-tar"): |
207 | raise PristineTarError("/usr/bin/pristine-tar is not available") |
208 | tree = self.branch.repository.revision_tree(revid) |
209 | |
210 | === modified file 'tests/test_import_dsc.py' |
211 | --- tests/test_import_dsc.py 2009-03-10 01:57:05 +0000 |
212 | +++ tests/test_import_dsc.py 2009-04-15 15:08:32 +0000 |
213 | @@ -103,9 +103,7 @@ |
214 | def test_upstream_tag_name(self): |
215 | db = self.db1 |
216 | upstream_v_no = "0.1" |
217 | - version_no = upstream_v_no + "-1" |
218 | - version = Version(version_no) |
219 | - self.assertEqual(db.upstream_tag_name(version), |
220 | + self.assertEqual(db.upstream_tag_name(upstream_v_no), |
221 | "upstream-" + upstream_v_no) |
222 | |
223 | def test_tag_version(self): |
224 | @@ -120,7 +118,7 @@ |
225 | def test_tag_upstream_version(self): |
226 | db = self.db1 |
227 | tree = self.up_tree1 |
228 | - version = Version("0.1-1") |
229 | + version = "0.1" |
230 | revid = tree.commit("one") |
231 | db.tag_upstream_version(version) |
232 | tag_name = db.upstream_tag_name(version) |
233 | @@ -143,7 +141,7 @@ |
234 | |
235 | def test_has_upstream_version(self): |
236 | db = self.db1 |
237 | - version = Version("0.1-1") |
238 | + version = "0.1" |
239 | self.assertFalse(db.has_upstream_version(version)) |
240 | self.assertFalse(db.has_upstream_version(version, self.fake_md5_1)) |
241 | self.do_commit_with_md5(self.up_tree1, "one", self.fake_md5_1) |
242 | @@ -151,11 +149,11 @@ |
243 | self.assertTrue(db.has_upstream_version(version)) |
244 | self.assertTrue(db.has_upstream_version(version, self.fake_md5_1)) |
245 | self.assertFalse(db.has_upstream_version(version, self.fake_md5_2)) |
246 | - version = Version("0.1-2") |
247 | + version = "0.1" |
248 | self.assertTrue(db.has_upstream_version(version)) |
249 | self.assertTrue(db.has_upstream_version(version, self.fake_md5_1)) |
250 | self.assertFalse(db.has_upstream_version(version, self.fake_md5_2)) |
251 | - version = Version("0.2-1") |
252 | + version = "0.2" |
253 | self.assertFalse(db.has_upstream_version(version)) |
254 | self.assertFalse(db.has_upstream_version(version, self.fake_md5_1)) |
255 | self.assertFalse(db.has_upstream_version(version, self.fake_md5_2)) |
256 | @@ -171,7 +169,7 @@ |
257 | def test_revid_of_upstream_version(self): |
258 | db = self.db1 |
259 | tree = self.up_tree1 |
260 | - version = Version("0.1-1") |
261 | + version = "0.1" |
262 | revid = tree.commit("one") |
263 | db.tag_upstream_version(version) |
264 | self.assertEqual(db.revid_of_upstream_version(version), revid) |
265 | @@ -363,12 +361,12 @@ |
266 | db = self.db1 |
267 | version1 = Version("0.1-1") |
268 | up_revid = self.up_tree1.commit("one") |
269 | - db.tag_upstream_version(version1) |
270 | + db.tag_upstream_version(version1.upstream_version) |
271 | self.assertEqual(db.get_parents_with_upstream(version1, [version1]), |
272 | [up_revid]) |
273 | db = self.db2 |
274 | self.up_tree2.pull(self.up_tree1.branch) |
275 | - db.tag_upstream_version(version1) |
276 | + db.tag_upstream_version(version1.upstream_version) |
277 | self.assertEqual(db.get_parents_with_upstream(version1, [version1]), |
278 | [up_revid]) |
279 | |
280 | @@ -379,7 +377,7 @@ |
281 | revid1 = self.tree1.commit("one") |
282 | db.tag_version(version1) |
283 | up_revid = self.up_tree1.commit("upstream one") |
284 | - db.tag_upstream_version(version1) |
285 | + db.tag_upstream_version(version1.upstream_version) |
286 | # No upstream parent |
287 | self.assertEqual(db.get_parents_with_upstream(version2, |
288 | [version2, version1]), [revid1]) |
289 | @@ -394,8 +392,8 @@ |
290 | self.db2.tag_version(version2) |
291 | up_revid1 = self.up_tree1.commit("upstream one") |
292 | self.up_tree2.pull(self.up_tree1.branch) |
293 | - self.db1.tag_upstream_version(version1) |
294 | - self.db2.tag_upstream_version(version2) |
295 | + self.db1.tag_upstream_version(version1.upstream_version) |
296 | + self.db2.tag_upstream_version(version2.upstream_version) |
297 | versions = [version3, version1, version2] |
298 | # No upstream parent |
299 | self.assertEqual(self.db2.get_parents_with_upstream(version3, |
300 | @@ -411,8 +409,8 @@ |
301 | self.db2.tag_version(version2) |
302 | up_revid1 = self.up_tree1.commit("upstream one") |
303 | self.up_tree2.pull(self.up_tree1.branch) |
304 | - self.db1.tag_upstream_version(version1) |
305 | - self.db2.tag_upstream_version(version2) |
306 | + self.db1.tag_upstream_version(version1.upstream_version) |
307 | + self.db2.tag_upstream_version(version2.upstream_version) |
308 | versions = [version3, version2, version1] |
309 | # No upstream parent |
310 | self.assertEqual(self.db1.get_parents_with_upstream(version3, |
311 | @@ -427,8 +425,8 @@ |
312 | self.db2.tag_version(version1) |
313 | up_revid1 = self.up_tree1.commit("upstream one") |
314 | up_revid2 = self.up_tree2.commit("upstream two") |
315 | - self.db1.tag_upstream_version(version1) |
316 | - self.db2.tag_upstream_version(version2) |
317 | + self.db1.tag_upstream_version(version1.upstream_version) |
318 | + self.db2.tag_upstream_version(version2.upstream_version) |
319 | versions = [version2, version1] |
320 | # Upstream parent as it is new upstream version |
321 | self.assertEqual(self.db2.get_parents_with_upstream(version2, |
322 | @@ -446,13 +444,13 @@ |
323 | revid3 = self.tree1.commit("three") |
324 | self.db1.tag_version(version3) |
325 | up_revid1 = self.up_tree1.commit("upstream one") |
326 | - self.db1.tag_upstream_version(version1) |
327 | + self.db1.tag_upstream_version(version1.upstream_version) |
328 | self.up_tree2.pull(self.up_tree1.branch) |
329 | - self.db2.tag_upstream_version(version2) |
330 | + self.db2.tag_upstream_version(version2.upstream_version) |
331 | up_revid2 = self.up_tree1.commit("upstream two") |
332 | - self.db1.tag_upstream_version(version3) |
333 | + self.db1.tag_upstream_version(version3.upstream_version) |
334 | self.up_tree2.pull(self.up_tree1.branch) |
335 | - self.db2.tag_upstream_version(version4) |
336 | + self.db2.tag_upstream_version(version4.upstream_version) |
337 | versions = [version4, version3, version2, version1] |
338 | # no upstream parent as the lesser branch has already merged it |
339 | self.assertEqual(self.db2.get_parents_with_upstream(version4, |
340 | @@ -464,9 +462,9 @@ |
341 | revid1 = self.tree1.commit("one") |
342 | self.db1.tag_version(version1) |
343 | up_revid1 = self.up_tree1.commit("upstream one") |
344 | - self.db1.tag_upstream_version(version1) |
345 | + self.db1.tag_upstream_version(version1.upstream_version) |
346 | up_revid2 = self.up_tree2.commit("different upstream one") |
347 | - self.db2.tag_upstream_version(version2) |
348 | + self.db2.tag_upstream_version(version2.upstream_version) |
349 | versions = [version2, version1] |
350 | # a previous test checked that this wouldn't give an |
351 | # upstream parent, but we are requiring one. |
352 | @@ -485,9 +483,9 @@ |
353 | self.db2.tag_version(version2) |
354 | self.db1.tag_version(version3) |
355 | up_revid1 = self.up_tree1.commit("upstream one") |
356 | - self.db1.tag_upstream_version(version1) |
357 | + self.db1.tag_upstream_version(version1.upstream_version) |
358 | self.up_tree2.pull(self.up_tree1.branch) |
359 | - self.db2.tag_upstream_version(version2) |
360 | + self.db2.tag_upstream_version(version2.upstream_version) |
361 | versions = [version3, version2, version1] |
362 | # This is a sync but we are diverged so we should get two |
363 | # parents |
364 | @@ -505,11 +503,11 @@ |
365 | self.db2.tag_version(version2) |
366 | self.db1.tag_version(version3) |
367 | up_revid1 = self.up_tree1.commit("upstream one") |
368 | - self.db1.tag_upstream_version(version1) |
369 | + self.db1.tag_upstream_version(version1.upstream_version) |
370 | self.up_tree2.pull(self.up_tree1.branch) |
371 | - self.db2.tag_upstream_version(version2) |
372 | + self.db2.tag_upstream_version(version2.upstream_version) |
373 | up_revid2 = self.up_tree1.commit("upstream two") |
374 | - self.db1.tag_upstream_version(version3) |
375 | + self.db1.tag_upstream_version(version3.upstream_version) |
376 | versions = [version3, version2, version1] |
377 | # This a sync, but we are diverged, so we should get two |
378 | # parents. There should be no upstream as the synced |
379 | @@ -528,14 +526,14 @@ |
380 | self.db2.tag_version(version2) |
381 | self.db1.tag_version(version3) |
382 | up_revid1 = self.up_tree1.commit("upstream one") |
383 | - self.db1.tag_upstream_version(version1) |
384 | + self.db1.tag_upstream_version(version1.upstream_version) |
385 | self.up_tree2.pull(self.up_tree1.branch) |
386 | - self.db2.tag_upstream_version(version2) |
387 | + self.db2.tag_upstream_version(version2.upstream_version) |
388 | up_revid2 = self.up_tree1.commit("upstream two") |
389 | - self.db1.tag_upstream_version(version3) |
390 | + self.db1.tag_upstream_version(version3.upstream_version) |
391 | versions = [version3, version2, version1] |
392 | up_revid3 = self.up_tree2.commit("different upstream two") |
393 | - self.db2.tag_upstream_version(version3) |
394 | + self.db2.tag_upstream_version(version3.upstream_version) |
395 | versions = [version3, version2, version1] |
396 | # test_get_parents_with_upstream_sync_new_upstream |
397 | # checks that there is not normally an upstream parent |
398 | @@ -602,57 +600,57 @@ |
399 | version1 = Version("0.1-1") |
400 | version2 = Version("0.2-1") |
401 | # With no versions tagged everything is None |
402 | - branch = self.db2.branch_to_pull_upstream_from(version1, |
403 | - self.fake_md5_1) |
404 | - self.assertEqual(branch, None) |
405 | - branch = self.db2.branch_to_pull_upstream_from(version1, |
406 | - self.fake_md5_2) |
407 | - self.assertEqual(branch, None) |
408 | - branch = self.db1.branch_to_pull_upstream_from(version1, |
409 | - self.fake_md5_1) |
410 | + branch = self.db2.branch_to_pull_upstream_from( |
411 | + version1.upstream_version, self.fake_md5_1) |
412 | + self.assertEqual(branch, None) |
413 | + branch = self.db2.branch_to_pull_upstream_from( |
414 | + version1.upstream_version, self.fake_md5_2) |
415 | + self.assertEqual(branch, None) |
416 | + branch = self.db1.branch_to_pull_upstream_from( |
417 | + version1.upstream_version, self.fake_md5_1) |
418 | self.assertEqual(branch, None) |
419 | self.do_commit_with_md5(self.up_tree1, "one", self.fake_md5_1) |
420 | - self.db1.tag_upstream_version(version1) |
421 | + self.db1.tag_upstream_version(version1.upstream_version) |
422 | # Version and md5 available, so we get the correct branch. |
423 | - branch = self.db2.branch_to_pull_upstream_from(version1, |
424 | - self.fake_md5_1) |
425 | + branch = self.db2.branch_to_pull_upstream_from( |
426 | + version1.upstream_version, self.fake_md5_1) |
427 | self.assertEqual(branch, self.db1) |
428 | # Otherwise (different version or md5) then we get None |
429 | - branch = self.db2.branch_to_pull_upstream_from(version1, |
430 | - self.fake_md5_2) |
431 | + branch = self.db2.branch_to_pull_upstream_from( |
432 | + version1.upstream_version, self.fake_md5_2) |
433 | self.assertEqual(branch, None) |
434 | - branch = self.db2.branch_to_pull_upstream_from(version2, |
435 | + branch = self.db2.branch_to_pull_upstream_from(version2.upstream_version, |
436 | self.fake_md5_1) |
437 | self.assertEqual(branch, None) |
438 | - branch = self.db2.branch_to_pull_upstream_from(version2, |
439 | + branch = self.db2.branch_to_pull_upstream_from(version2.upstream_version, |
440 | self.fake_md5_2) |
441 | self.assertEqual(branch, None) |
442 | # And we don't get a branch for the one that already has |
443 | # the version |
444 | - branch = self.db1.branch_to_pull_upstream_from(version1, |
445 | - self.fake_md5_1) |
446 | + branch = self.db1.branch_to_pull_upstream_from( |
447 | + version1.upstream_version, self.fake_md5_1) |
448 | self.assertEqual(branch, None) |
449 | self.up_tree2.pull(self.up_tree1.branch) |
450 | - self.db2.tag_upstream_version(version1) |
451 | + self.db2.tag_upstream_version(version1.upstream_version) |
452 | # And we get the greatest branch when two lesser branches |
453 | # have what we are looking for. |
454 | - branch = self.db3.branch_to_pull_upstream_from(version1, |
455 | - self.fake_md5_1) |
456 | + branch = self.db3.branch_to_pull_upstream_from( |
457 | + version1.upstream_version, self.fake_md5_1) |
458 | self.assertEqual(branch, self.db2) |
459 | # If the branches have diverged then we don't get a branch. |
460 | self.up_tree3.commit("three") |
461 | - branch = self.db3.branch_to_pull_upstream_from(version1, |
462 | - self.fake_md5_1) |
463 | + branch = self.db3.branch_to_pull_upstream_from( |
464 | + version1.upstream_version, self.fake_md5_1) |
465 | self.assertEqual(branch, None) |
466 | |
467 | def test_pull_from_lesser_branch_no_upstream(self): |
468 | version = Version("0.1-1") |
469 | self.do_commit_with_md5(self.up_tree1, "upstream one", |
470 | self.fake_md5_1) |
471 | - self.db1.tag_upstream_version(version) |
472 | + self.db1.tag_upstream_version(version.upstream_version) |
473 | up_revid = self.do_commit_with_md5(self.up_tree2, "upstream two", |
474 | self.fake_md5_1) |
475 | - self.db2.tag_upstream_version(version) |
476 | + self.db2.tag_upstream_version(version.upstream_version) |
477 | revid = self.do_commit_with_md5(self.tree1, "one", self.fake_md5_2) |
478 | self.db1.tag_version(version) |
479 | self.assertNotEqual(self.tree2.branch.last_revision(), revid) |
480 | @@ -660,14 +658,14 @@ |
481 | self.assertEqual(self.tree2.branch.last_revision(), revid) |
482 | self.assertEqual(self.up_tree2.branch.last_revision(), up_revid) |
483 | self.assertEqual(self.db2.revid_of_version(version), revid) |
484 | - self.assertEqual(self.db2.revid_of_upstream_version(version), |
485 | - up_revid) |
486 | + self.assertEqual(self.db2.revid_of_upstream_version( |
487 | + version.upstream_version), up_revid) |
488 | |
489 | def test_pull_from_lesser_branch_with_upstream(self): |
490 | version = Version("0.1-1") |
491 | up_revid = self.do_commit_with_md5(self.up_tree1, "upstream one", |
492 | self.fake_md5_1) |
493 | - self.db1.tag_upstream_version(version) |
494 | + self.db1.tag_upstream_version(version.upstream_version) |
495 | revid = self.do_commit_with_md5(self.tree1, "one", self.fake_md5_2) |
496 | self.db1.tag_version(version) |
497 | self.assertNotEqual(self.tree2.branch.last_revision(), revid) |
498 | @@ -676,11 +674,11 @@ |
499 | self.assertEqual(self.tree2.branch.last_revision(), revid) |
500 | self.assertEqual(self.up_tree2.branch.last_revision(), up_revid) |
501 | self.assertEqual(self.db2.revid_of_version(version), revid) |
502 | - self.assertEqual(self.db2.revid_of_upstream_version(version), |
503 | - up_revid) |
504 | + self.assertEqual(self.db2.revid_of_upstream_version( |
505 | + version.upstream_version), up_revid) |
506 | |
507 | def test_pull_upstream_from_branch(self): |
508 | - version = Version("0.1-1") |
509 | + version = "0.1" |
510 | up_revid = self.do_commit_with_md5(self.up_tree1, "upstream one", |
511 | self.fake_md5_1) |
512 | self.db1.tag_upstream_version(version) |
513 | @@ -752,12 +750,14 @@ |
514 | os.mkdir(basedir) |
515 | write_to_file(os.path.join(basedir, "README"), "Hi\n") |
516 | write_to_file(os.path.join(basedir, "BUGS"), "") |
517 | - self.db1.import_upstream(basedir, version, self.fake_md5_1, []) |
518 | + self.db1.import_upstream(basedir, version.upstream_version, |
519 | + self.fake_md5_1, []) |
520 | tree = self.up_tree1 |
521 | branch = tree.branch |
522 | rh = branch.revision_history() |
523 | self.assertEqual(len(rh), 1) |
524 | - self.assertEqual(self.db1.revid_of_upstream_version(version), rh[0]) |
525 | + self.assertEqual(self.db1.revid_of_upstream_version( |
526 | + version.upstream_version), rh[0]) |
527 | rev = branch.repository.get_revision(rh[0]) |
528 | self.assertEqual(rev.message, |
529 | "Import upstream version %s" % str(version.upstream_version)) |
530 | @@ -772,19 +772,21 @@ |
531 | write_to_file(os.path.join(basedir, "README"), "Hi\n") |
532 | write_to_file(os.path.join(basedir, "BUGS"), "") |
533 | write_to_file(os.path.join(basedir, "COPYING"), "") |
534 | - self.db1.import_upstream(basedir, version1, self.fake_md5_1, []) |
535 | + self.db1.import_upstream(basedir, version1.upstream_version, |
536 | + self.fake_md5_1, []) |
537 | basedir = name + "-" + str(version2.upstream_version) |
538 | os.mkdir(basedir) |
539 | write_to_file(os.path.join(basedir, "README"), "Now even better\n") |
540 | write_to_file(os.path.join(basedir, "BUGS"), "") |
541 | write_to_file(os.path.join(basedir, "NEWS"), "") |
542 | - self.db1.import_upstream(basedir, version2, self.fake_md5_2, |
543 | + self.db1.import_upstream(basedir, version2.upstream_version, |
544 | + self.fake_md5_2, |
545 | [self.up_tree1.branch.last_revision()]) |
546 | tree = self.up_tree1 |
547 | branch = tree.branch |
548 | rh = branch.revision_history() |
549 | self.assertEqual(len(rh), 2) |
550 | - self.assertEqual(self.db1.revid_of_upstream_version(version2), rh[1]) |
551 | + self.assertEqual(self.db1.revid_of_upstream_version(version2.upstream_version), rh[1]) |
552 | rev = branch.repository.get_revision(rh[1]) |
553 | self.assertEqual(rev.message, |
554 | "Import upstream version %s" % str(version2.upstream_version)) |
555 | @@ -1201,7 +1203,8 @@ |
556 | self.assertEqual(self.db1.revid_of_version(version1), rh1[1]) |
557 | self.assertEqual(self.db1.revid_of_version(version2), rh1[2]) |
558 | self.assertEqual(self.db1.revid_of_version(version3), rh1[3]) |
559 | - self.assertEqual(self.db1.revid_of_upstream_version(version1), |
560 | + self.assertEqual( |
561 | + self.db1.revid_of_upstream_version(version1.upstream_version), |
562 | up_rh1[0]) |
563 | self.tree1.lock_read() |
564 | self.addCleanup(self.tree1.unlock) |
565 | @@ -1252,9 +1255,11 @@ |
566 | self.assertEqual(self.db1.revid_of_version(version1), rh1[1]) |
567 | self.assertEqual(self.db1.revid_of_version(version2), rh1[2]) |
568 | self.assertEqual(self.db1.revid_of_version(version3), rh1[3]) |
569 | - self.assertEqual(self.db1.revid_of_upstream_version(version1), |
570 | + self.assertEqual( |
571 | + self.db1.revid_of_upstream_version(version1.upstream_version), |
572 | up_rh1[0]) |
573 | - self.assertEqual(self.db1.revid_of_upstream_version(version3), |
574 | + self.assertEqual( |
575 | + self.db1.revid_of_upstream_version(version3.upstream_version), |
576 | up_rh1[1]) |
577 | self.tree1.lock_read() |
578 | self.addCleanup(self.tree1.unlock) |
579 | @@ -1304,9 +1309,11 @@ |
580 | self.assertEqual(self.db1.revid_of_version(version1), rh1[1]) |
581 | self.assertEqual(self.db1.revid_of_version(version2), rh1[2]) |
582 | self.assertEqual(self.db1.revid_of_version(version3), rh1[3]) |
583 | - self.assertEqual(self.db1.revid_of_upstream_version(version1), |
584 | + self.assertEqual( |
585 | + self.db1.revid_of_upstream_version(version1.upstream_version), |
586 | up_rh1[0]) |
587 | - self.assertEqual(self.db1.revid_of_upstream_version(version3), |
588 | + self.assertEqual( |
589 | + self.db1.revid_of_upstream_version(version3.upstream_version), |
590 | up_rh1[1]) |
591 | self.tree1.lock_read() |
592 | self.addCleanup(self.tree1.unlock) |
593 | |
594 | === modified file 'tests/test_upstream.py' |
595 | --- tests/test_upstream.py 2009-03-08 23:18:01 +0000 |
596 | +++ tests/test_upstream.py 2009-04-15 15:08:32 +0000 |
597 | @@ -109,15 +109,15 @@ |
598 | self.tree = None |
599 | self.branch = None |
600 | self.package = None |
601 | - self.version = None |
602 | + self.upstream_version = None |
603 | self.target_filename = None |
604 | |
605 | - def provide(self, tree, branch, package, version, target_filename): |
606 | + def provide(self, tree, branch, package, upstream_version, target_filename): |
607 | self.called_times += 1 |
608 | self.tree = tree |
609 | self.branch = branch |
610 | self.package = package |
611 | - self.version = version |
612 | + self.upstream_version = upstream_version |
613 | self.target_filename = target_filename |
614 | if self.find: |
615 | self.create_target(target_filename) |
616 | |
617 | === modified file 'upstream.py' |
618 | --- upstream.py 2009-03-07 23:54:46 +0000 |
619 | +++ upstream.py 2009-04-15 15:08:32 +0000 |
620 | @@ -276,7 +276,7 @@ |
621 | def provide_with_pristine_tar(self, target_dir): |
622 | target_filename = os.path.join(target_dir, self._tarball_name()) |
623 | return self._pristine_provider(self.tree, self.branch, self.package, |
624 | - self.version, target_filename) |
625 | + self.version.upstream_version, target_filename) |
626 | |
627 | def provide_with_get_orig_source(self, target_dir): |
628 | if self.larstiq: |
Hi James,
The attached patch changes various builddeb functions that only use an version- specific Version object.
upstream version to take an upstream version string rather than a
Debian-
Cheers,
Jelmer
--