Merge lp:~jelmer/bzr-builddeb/627718-auto-v3 into lp:bzr-builddeb

Proposed by Jelmer Vernooij
Status: Merged
Merged at revision: 507
Proposed branch: lp:~jelmer/bzr-builddeb/627718-auto-v3
Merge into: lp:bzr-builddeb
Prerequisite: lp:~jelmer/bzr-builddeb/tarfilesource
Diff against target: 36 lines (+7/-1)
2 files modified
cmds.py (+4/-0)
debian/changelog (+3/-1)
To merge this branch: bzr merge lp:~jelmer/bzr-builddeb/627718-auto-v3
Reviewer Review Type Date Requested Status
James Westby Approve
Review via email: mp+48314@code.launchpad.net

Description of the change

Automatically determine if "bzr merge-upstream" is being used in a v3 source package to see if .tar.bz2 orig tarballs are allowed.

Should we kill the --v3 option?

To post a comment you must log in.
Revision history for this message
James Westby (james-w) wrote :

Could we perhaps lose the magic strings?

Does --v3 work to turn a package in to v3 for the first time? If so
then I would keep it, otherwise we might as well drop it.

Thanks,

James

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cmds.py'
2--- cmds.py 2011-02-02 13:48:00 +0000
3+++ cmds.py 2011-02-02 13:48:00 +0000
4@@ -105,6 +105,7 @@
5 find_last_distribution,
6 find_previous_upload,
7 get_export_upstream_revision,
8+ get_source_format,
9 guess_build_type,
10 lookup_distribution,
11 open_file,
12@@ -714,6 +715,9 @@
13 target_dir = tempfile.mkdtemp() # FIXME: Cleanup?
14 location = primary_upstream_source.fetch_tarball(
15 package, version, target_dir)
16+ if v3 is None:
17+ source_format = get_source_format(tree)
18+ v3 = (source_format in ["3.0 (quilt)", "3.0 (native)"])
19 tarball_filename = self._get_tarball(config, tree, package,
20 version, upstream_branch, upstream_revision, v3,
21 location)
22
23=== modified file 'debian/changelog'
24--- debian/changelog 2011-01-31 23:15:42 +0000
25+++ debian/changelog 2011-02-02 13:48:00 +0000
26@@ -41,8 +41,10 @@
27 build type. LP: #655277
28 * Fix finding upstream tarball when get-orig-source is not available.
29 Closes: #552893
30+ * merge-upstream now looks at the package source format to see what
31+ kind of compression is supported on tarballs. LP: #627718
32
33- -- Jelmer Vernooij <jelmer@debian.org> Tue, 01 Feb 2011 00:13:07 +0100
34+ -- Jelmer Vernooij <jelmer@debian.org> Wed, 02 Feb 2011 14:40:55 +0100
35
36 bzr-builddeb (2.5) unstable; urgency=low
37

Subscribers

People subscribed via source and target branches