Merge lp:~jelmer/bzr-builddeb/622678-epoch into lp:bzr-builddeb

Proposed by Jelmer Vernooij
Status: Merged
Merged at revision: 502
Proposed branch: lp:~jelmer/bzr-builddeb/622678-epoch
Merge into: lp:bzr-builddeb
Diff against target: 64 lines (+11/-3)
3 files modified
debian/changelog (+2/-1)
merge_upstream.py (+5/-2)
tests/test_merge_upstream.py (+4/-0)
To merge this branch: bzr merge lp:~jelmer/bzr-builddeb/622678-epoch
Reviewer Review Type Date Requested Status
James Westby Approve
Review via email: mp+47887@code.launchpad.net

Description of the change

Keep the epoch around when generating a new upstream version string.

To post a comment you must log in.
Revision history for this message
James Westby (james-w) wrote :

Great, thanks.

James

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-01-29 02:11:01 +0000
3+++ debian/changelog 2011-01-29 03:32:53 +0000
4@@ -34,8 +34,9 @@
5 * Add --snapshot option to merge-upstream.
6 * 'bzr merge-upstream' now also works in merge mode, and will simply
7 add a new entry for new upstream versions.
8+ * merge-upstream will now keep epochs around. LP: #622678
9
10- -- Jelmer Vernooij <jelmer@debian.org> Fri, 28 Jan 2011 15:13:22 +0100
11+ -- Jelmer Vernooij <jelmer@debian.org> Sat, 29 Jan 2011 04:29:41 +0100
12
13 bzr-builddeb (2.5) unstable; urgency=low
14
15
16=== modified file 'merge_upstream.py'
17--- merge_upstream.py 2011-01-24 02:16:17 +0000
18+++ merge_upstream.py 2011-01-29 03:32:53 +0000
19@@ -180,11 +180,12 @@
20 return None
21
22
23-def package_version(upstream_version, distribution_name):
24+def package_version(upstream_version, distribution_name, epoch=None):
25 """Determine the package version for a new upstream.
26
27 :param upstream_version: Upstream version string
28 :param distribution_name: Distribution the package is for
29+ :param epoch: Optional epoch
30 """
31 assert isinstance(upstream_version, str), \
32 "upstream_version should be a str, not %s" % str(
33@@ -193,6 +194,7 @@
34 ret = Version("%s-0ubuntu1" % upstream_version)
35 else:
36 ret = Version("%s-1" % upstream_version)
37+ ret.epoch = epoch
38 return ret
39
40
41@@ -231,7 +233,8 @@
42 type(upstream_version))
43 entry_description = upstream_merge_changelog_line(upstream_version)
44 proc = subprocess.Popen(["dch", "-v",
45- str(package_version(upstream_version, distribution_name)),
46+ str(package_version(upstream_version, distribution_name,
47+ changelog.epoch)),
48 "-D", "UNRELEASED", "--release-heuristic", "changelog", entry_description],
49 cwd=tree.basedir)
50 proc.wait()
51
52=== modified file 'tests/test_merge_upstream.py'
53--- tests/test_merge_upstream.py 2011-01-17 22:18:44 +0000
54+++ tests/test_merge_upstream.py 2011-01-29 03:32:53 +0000
55@@ -159,6 +159,10 @@
56 self.assertEquals(Version("1.2-1-0ubuntu1"),
57 package_version("1.2-1", "ubuntu"))
58
59+ def test_ubuntu_with_epoch(self):
60+ self.assertEquals(Version("3:1.2-1-0ubuntu1"),
61+ package_version("1.2-1", "ubuntu", "3"))
62+
63
64 class UpstreamMergeChangelogLineTests(TestCase):
65

Subscribers

People subscribed via source and target branches