Merge lp:~jelmer/byoci/setuptools into lp:byoci

Proposed by Jelmer Vernooij
Status: Needs review
Proposed branch: lp:~jelmer/byoci/setuptools
Merge into: lp:byoci
Diff against target: 14 lines (+2/-2)
1 file modified
containers/byov.conf (+2/-2)
To merge this branch: bzr merge lp:~jelmer/byoci/setuptools
Reviewer Review Type Date Requested Status
Vincent Ladeuil Needs Fixing
Review via email: mp+384785@code.launchpad.net

Commit message

Install setuptools from apt.

Description of the change

Install setuptools from apt.

The version of setuptools in pip no longer supports Python 2, and
so any builds that try to build Breezy on Python 2 fail.

See for example https://ci.breezy-vcs.org/job/brz/job/brz-land/737/console

To post a comment you must log in.
Revision history for this message
Vincent Ladeuil (vila) wrote :

This should go into the breezy byov.conf ;-)

Granted, containers/byov.conf should be cleaned up to avoid such confusion, but it's only there to provide default values that can and should be defined in the projects themselves.

review: Needs Fixing

Unmerged revisions

221. By Jelmer Vernooij

Install setuptools from apt.

The version of setuptools in pip no longer supports Python 2.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'containers/byov.conf'
2--- containers/byov.conf 2018-09-15 17:18:11 +0000
3+++ containers/byov.conf 2020-05-28 21:47:08 +0000
4@@ -36,8 +36,8 @@
5
6 # FIXME: Arguably this should be vm.build_deps=brz but it requires either an
7 # available package or at least a debian/ dir ? -- vila 2018-02-23
8-brz.build_deps = gcc, debhelper, python, python-all-dev, python3-all-dev, python-configobj, python3-configobj, python-docutils, python3-docutils, python-paramiko, python3-paramiko, python-subunit, python3-subunit, python-testtools, python3-testtools, subunit, cython, cython3, python-fastimport
9-subunit.build_deps = python-testscenarios, python3-testscenarios, python-testtools, python3-testtools
10+brz.build_deps = gcc, debhelper, python, python-all-dev, python3-all-dev, python-configobj, python3-configobj, python-docutils, python3-docutils, python-paramiko, python3-paramiko, python-subunit, python3-subunit, python-testtools, python3-testtools, subunit, cython, cython3, python-fastimport, python-setuptools
11+subunit.build_deps = python-testscenarios, python3-testscenarios, python-testtools, python3-testtools, python3-setuptools
12 vm.packages = {brz.build_deps}, {subunit.build_deps}, bzr, python-junitxml
13 [brz-xenial]
14 vm.release = xenial

Subscribers

People subscribed via source and target branches