Breezy

Merge lp:~jelmer/brz/update-permission-dnied into lp:brz/3.1

  1. update-permission-dnied
  2. Merge into 3.1
Proposed by Jelmer Vernooij
Status: Merged
Approved by: Jelmer Vernooij
Approved revision: no longer in the source branch.
Merge reported by: The Breezy Bot
Merged at revision: not available
Proposed branch: lp:~jelmer/brz/update-permission-dnied
Merge into: lp:brz/3.1
Diff against target: 12 lines (+2/-0)
1 file modified
breezy/plugins/gitlab/hoster.py (+2/-0)
To merge this branch: bzr merge lp:~jelmer/brz/update-permission-dnied
Reviewer Review Type Date Requested Status
Jelmer Vernooij Approve
Review via email: mp+388532@code.launchpad.net

Commit message

Properly raise PermissionDenied when updating GitLab merge requests.

Description of the change

Properly raise PermissionDenied when updating GitLab merge requests.

To post a comment you must log in.
Revision history for this message
Jelmer Vernooij (jelmer) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'breezy/plugins/gitlab/hoster.py'
2--- breezy/plugins/gitlab/hoster.py 2020-08-02 18:29:09 +0000
3+++ breezy/plugins/gitlab/hoster.py 2020-08-02 20:28:37 +0000
4@@ -467,6 +467,8 @@
5 response = self._api_request('PUT', path, fields=mr)
6 if response.status == 200:
7 return json.loads(response.data)
8+ if response.status == 403:
9+ raise errors.PermissionDenied(response.text)
10 _unexpected_status(path, response)
11
12 def _post_merge_request_note(self, project_id, iid, kwargs):

Subscribers

People subscribed via source and target branches