Merge lp:~jelmer/brz/test-ui-isolation into lp:brz

Proposed by Jelmer Vernooij
Status: Merged
Approved by: Jelmer Vernooij
Approved revision: no longer in the source branch.
Merge reported by: The Breezy Bot
Merged at revision: not available
Proposed branch: lp:~jelmer/brz/test-ui-isolation
Merge into: lp:brz
Diff against target: 30 lines (+4/-5)
2 files modified
breezy/tests/test_ui.py (+1/-1)
doc/en/release-notes/brz-3.0.txt (+3/-4)
To merge this branch: bzr merge lp:~jelmer/brz/test-ui-isolation
Reviewer Review Type Date Requested Status
Martin Packman Approve
Review via email: mp+325197@code.launchpad.net

Commit message

Fix test isolation of breezy.tests.test_ui.

Description of the change

Fix test isolation of breezy.tests.test_ui.

To post a comment you must log in.
Revision history for this message
Martin Packman (gz) wrote :

This one is on me. Changed the class when doing the other ui stuff, presumably because it was using TestCaseWithTransport and no transport? Config stuff needs tempdir...

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'breezy/tests/test_ui.py'
2--- breezy/tests/test_ui.py 2017-05-25 01:35:55 +0000
3+++ breezy/tests/test_ui.py 2017-06-07 01:28:26 +0000
4@@ -36,7 +36,7 @@
5 )
6
7
8-class TestUIConfiguration(tests.TestCase):
9+class TestUIConfiguration(tests.TestCaseInTempDir):
10
11 def test_output_encoding_configuration(self):
12 enc = next(fixtures.generate_unicode_encodings())
13
14=== modified file 'doc/en/release-notes/brz-3.0.txt'
15--- doc/en/release-notes/brz-3.0.txt 2017-06-06 00:40:32 +0000
16+++ doc/en/release-notes/brz-3.0.txt 2017-06-07 01:28:26 +0000
17@@ -111,10 +111,9 @@
18 Testing
19 *******
20
21-.. Fixes and changes that are only relevant to brz's test framework and
22- suite. This can include new facilities for writing tests, fixes to
23- spurious test failures and changes to the way things should be tested.
24-
25+ * A test isolation issue in ``breezy.tests.test_ui`` was fixed,
26+ which caused ``output_encoding = iso-8859-1`` to be added to the
27+ users' bazaar.conf. (Jelmer Vernooij)
28
29 ..
30 vim: tw=74 ft=rst ff=unix

Subscribers

People subscribed via source and target branches