Merge lp:~jelmer/brz/symlink-dev-null into lp:brz

Proposed by Jelmer Vernooij on 2018-09-18
Status: Merged
Approved by: Jelmer Vernooij on 2018-09-20
Approved revision: 7124
Merge reported by: The Breezy Bot
Merged at revision: not available
Proposed branch: lp:~jelmer/brz/symlink-dev-null
Merge into: lp:brz
Diff against target: 27 lines (+5/-1)
2 files modified
breezy/tests/test_osutils.py (+3/-1)
doc/en/release-notes/brz-3.0.txt (+2/-0)
To merge this branch: bzr merge lp:~jelmer/brz/symlink-dev-null
Reviewer Review Type Date Requested Status
Martin Packman 2018-09-18 Approve on 2018-09-20
Review via email: mp+355166@code.launchpad.net

Commit message

Allow /dev/null to be a symlink.

Description of the change

Allow /dev/null to be a symlink.

Necessary on Illumos.

To post a comment you must log in.
Martin Packman (gz) wrote :

Seems perfectly reasonable.

review: Approve
The Breezy Bot (the-breezy-bot) wrote :

Running landing tests failed
https://ci.breezy-vcs.org/job/land-brz/494/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'breezy/tests/test_osutils.py'
2--- breezy/tests/test_osutils.py 2018-09-11 07:31:44 +0000
3+++ breezy/tests/test_osutils.py 2018-09-18 02:09:18 +0000
4@@ -313,7 +313,9 @@
5 if e.errno not in (errno.ENOENT,):
6 raise
7 else:
8- self.assertEqual('chardev', osutils.file_kind('/dev/null'))
9+ self.assertEqual(
10+ 'chardev',
11+ osutils.file_kind(os.path.realpath('/dev/null')))
12
13 mkfifo = getattr(os, 'mkfifo', None)
14 if mkfifo:
15
16=== modified file 'doc/en/release-notes/brz-3.0.txt'
17--- doc/en/release-notes/brz-3.0.txt 2018-09-16 09:45:55 +0000
18+++ doc/en/release-notes/brz-3.0.txt 2018-09-18 02:09:18 +0000
19@@ -274,6 +274,8 @@
20 Testing
21 *******
22
23+ * Allow /dev/null to be a symlink to a chardev. (Igo Pashev, #832257)
24+
25 * A test isolation issue in ``breezy.tests.test_ui`` was fixed,
26 which caused ``output_encoding = iso-8859-1`` to be added to the
27 users' bazaar.conf. (Jelmer Vernooń≥)

Subscribers

People subscribed via source and target branches