Merge lp:~jelmer/brz/segmentsurl into lp:brz

[Jelmer Vernooij]

Raise better error when subsegments lack =.

=== modified file 'breezy/tests/test_urlutils.py'
--- breezy/tests/test_urlutils.py	2018-11-23 03:06:01 +0000
+++ breezy/tests/test_urlutils.py	2019-02-16 03:08:36 +0000
@@ -599,6 +599,8 @@
         self.assertEqual(("foo/base,key1=val1/other/elements",
                           {"key2": "val2"}), split_segment_parameters(
             "foo/base,key1=val1/other/elements,key2=val2"))
+        self.assertRaises(urlutils.InvalidURL, split_segment_parameters,
+            "foo/base,key1")
         # TODO: Check full URLs as well as relative references
 
     def test_win32_strip_local_trailing_slash(self):

=== modified file 'breezy/urlutils.py'
--- breezy/urlutils.py	2018-11-12 01:41:38 +0000
+++ breezy/urlutils.py	2019-02-16 03:08:36 +0000
@@ -561,7 +561,10 @@
     (base_url, subsegments) = split_segment_parameters_raw(url)
     parameters = {}
     for subsegment in subsegments:
-        (key, value) = subsegment.split("=", 1)
+        try:
+            (key, value) = subsegment.split("=", 1)
+        except ValueError:
+            raise InvalidURL(url, "missing = in subsegment")
         if not isinstance(key, str):
             raise TypeError(key)
         if not isinstance(value, str):

=== modified file 'doc/en/release-notes/brz-3.0.txt'
--- doc/en/release-notes/brz-3.0.txt	2019-02-14 06:21:45 +0000
+++ doc/en/release-notes/brz-3.0.txt	2019-02-16 03:08:36 +0000
@@ -230,6 +230,9 @@
 * Don't report .git files as unknown files.
   (Jelmer Vernooij, Debian Bug #921240)
 
+* Raise better error when path subsegments lack =.
+  (Jelmer Vernooij, #891483)
+
 Documentation
 *************