Merge lp:~jelmer/brz/revert-http-redirect into lp:brz

[Jelmer Vernooij]

Rollback https://code.launchpad.net/~jelmer/brz/python3-git-fix-http/+merge/356238

Rollback https://code.launchpad.net/~jelmer/brz/python3-git-fix-http/+merge/356238

This breaks HTTP access for Git with currently released versions of Git.
Clearly this code needs better tests; I'll propose this branch again with tests.

[Jelmer Vernooij (jelmer)]

review: Approve

[The Breezy Bot (the-breezy-bot)]

There was nothing to merge
https://ci.breezy-vcs.org/job/land-brz/519/

=== modified file 'breezy/git/remote.py'
--- breezy/git/remote.py	2018-10-13 19:53:32 +0000
+++ breezy/git/remote.py	2018-10-14 12:58:20 +0000
@@ -636,8 +636,9 @@
         :param data: Request data.
         :param allow_compression: Allow GZipped communication.
         :return: Tuple (`response`, `read`), where response is an `urllib3`
-            response object with additional `content_type` property,
-            and `read` is a consumable read method for the response data.
+            response object with additional `content_type` and
+            `redirect_location` properties, and `read` is a consumable read
+            method for the response data.
         """
         from breezy.transport.http._urllib2_wrappers import Request
         headers['User-agent'] = user_agent_for_github()
@@ -677,6 +678,7 @@
                 self._response = response
                 self.status = response.code
                 self.content_type = response.getheader("Content-Type")
+                self.redirect_location = response.geturl()
 
             def close(self):
                 self._response.close()