Merge lp:~jelmer/brz/local-fetch-progress into lp:brz

Proposed by Jelmer Vernooij on 2018-09-29
Status: Merged
Approved by: Jelmer Vernooij on 2018-10-13
Approved revision: 7132
Merge reported by: The Breezy Bot
Merged at revision: not available
Proposed branch: lp:~jelmer/brz/local-fetch-progress
Merge into: lp:brz
Diff against target: 20 lines (+9/-1)
1 file modified
breezy/git/interrepo.py (+9/-1)
To merge this branch: bzr merge lp:~jelmer/brz/local-fetch-progress
Reviewer Review Type Date Requested Status
Martin Packman 2018-09-29 Approve on 2018-10-13
Review via email: mp+355878@code.launchpad.net

Commit message

Add progress indication for local git->git fetches.

Description of the change

Add progress indication for local git->git fetches.

To post a comment you must log in.
Martin Packman (gz) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'breezy/git/interrepo.py'
2--- breezy/git/interrepo.py 2018-09-12 00:38:27 +0000
3+++ breezy/git/interrepo.py 2018-09-29 22:56:36 +0000
4@@ -710,7 +710,15 @@
5 raise LossyPushToSameVCS(self.source, self.target)
6 if limit is not None:
7 raise FetchLimitUnsupported(self)
8- refs = self.source._git.fetch(self.target._git, determine_wants)
9+ from .remote import DefaultProgressReporter
10+ pb = ui.ui_factory.nested_progress_bar()
11+ progress = DefaultProgressReporter(pb).progress
12+ try:
13+ refs = self.source._git.fetch(
14+ self.target._git, determine_wants,
15+ progress=progress)
16+ finally:
17+ pb.finished()
18 return (None, None, refs)
19
20 @staticmethod

Subscribers

People subscribed via source and target branches